Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: src/globals.h

Issue 549079: Support for MIPS in architecture independent files.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/globals.h
===================================================================
--- src/globals.h (revision 3220)
+++ src/globals.h (working copy)
@@ -46,6 +46,9 @@
#elif defined(__ARMEL__)
#define V8_HOST_ARCH_ARM 1
#define V8_HOST_ARCH_32_BIT 1
+#elif defined(_MIPS_ARCH_MIPS32R2)
+#define V8_HOST_ARCH_MIPS 1
+#define V8_HOST_ARCH_32_BIT 1
#else
#error Your host architecture was not detected as supported by v8
#endif
@@ -53,6 +56,8 @@
#if defined(V8_TARGET_ARCH_X64) || defined(V8_TARGET_ARCH_IA32)
#define V8_TARGET_CAN_READ_UNALIGNED 1
#elif V8_TARGET_ARCH_ARM
+#elif V8_TARGET_ARCH_MIPS
+#define V8_TARGET_CAN_READ_UNALIGNED 0
Søren Thygesen Gjesse 2010/01/19 22:59:12 defining V8_TARGET_CAN_READ_UNALIGNED to 0 should
Alexandre 2010/01/22 23:08:42 Removed. On 2010/01/19 22:59:12, Søren Gjesse wrot
#else
#error Your target architecture is not supported by v8
#endif
@@ -169,7 +174,16 @@
reinterpret_cast<Address>(V8_UINT64_C(0x1beefdad0beefdad));
#else
const Address kZapValue = reinterpret_cast<Address>(0xdeadbeed);
+#ifndef V8_TARGET_ARCH_MIPS
const Address kHandleZapValue = reinterpret_cast<Address>(0xbaddead);
+#else
+// On mips 0xbaddead is the encoding of jump to 0xeb77ab4.
Søren Thygesen Gjesse 2010/01/19 22:59:12 I don't think this is important. The handle zap va
Alexandre 2010/01/22 23:08:42 I wrote this in the early development stage. It ca
+// This can be misleading when debugging and developping as we get a segfault
+// instead of an illegal instruction when executing it.
+// The 0b111011 opcode is reserved for future use. Executing this instruction
+// raises a Reserved Instruction Exception error on MIPS not using this opcode.
+const Address kHandleZapValue = reinterpret_cast<Address>(0xec000000);
+#endif
const Address kFromSpaceZapValue = reinterpret_cast<Address>(0xbeefdad);
#endif

Powered by Google App Engine
This is Rietveld 408576698