Support for MIPS in architecture independent files....

src/jump-target.h

Index: src/jump-target.h
===================================================================
--- src/jump-target.h	(revision 3220)
+++ src/jump-target.h	(working copy)
@@ -113,8 +113,13 @@
   // Emit a conditional branch to the target.  There must be a current
   // frame at the branch.  The current frame will fall through to the
   // code after the branch.
+#ifndef V8_TARGET_ARCH_MIPS

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

Like in codegen.h having a platform specific #ifdef in a platform independent
file should be avoided.

[Alexandre, 2010/01/22 23:08:42]

Same comment (see codegen.h). We need this on MIPS.
On 2010/01/19 22:59:12, Søren Gjesse wrote:

   virtual void Branch(Condition cc, Hint hint = no_hint);
   virtual void Branch(Condition cc, Result* arg, Hint hint = no_hint);
+#else
+  virtual void Branch(Condition cc, Hint hint = no_hint, Register src1 = zero_reg, const Operand& src2 = Operand(zero_reg));

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

Long line, see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Line_L....

[Alexandre, 2010/01/22 23:08:42]

Style issue fixed.
On 2010/01/19 22:59:12, Søren Gjesse wrote:

+  virtual void Branch(Condition cc, Result* arg, Hint hint = no_hint, Register src1 = zero_reg, const Operand& src2 = Operand(zero_reg));
+#endif
 
   // Bind a jump target.  If there is no current frame at the binding
   // site, there must be at least one frame reaching via a forward
@@ -153,7 +158,11 @@
   // Implementations of Jump, Branch, and Bind with all arguments and
   // return values using the virtual frame.
   void DoJump();
+#ifndef V8_TARGET_ARCH_MIPS

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

See above.

   void DoBranch(Condition cc, Hint hint);
+#else
+  void DoBranch(Condition cc, Hint hint, Register src1 = zero_reg, const Operand& src2 = Operand(zero_reg));

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

See above.

+#endif
   void DoBind();
 
  private:
@@ -210,8 +219,15 @@
   // Emit a conditional branch to the target.  There must be a current
   // frame at the branch.  The current frame will fall through to the
   // code after the branch.

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

See above.

+#ifndef V8_TARGET_ARCH_MIPS
   virtual void Branch(Condition cc, Hint hint = no_hint);
   virtual void Branch(Condition cc, Result* arg, Hint hint = no_hint);
+#else
+  virtual void Branch(Condition cc, Hint hint = no_hint,
+      Register src1 = zero_reg, const Operand& src2 = Operand(zero_reg));
+  virtual void Branch(Condition cc, Result* arg, Hint hint = no_hint,
+      Register src1 = zero_reg, const Operand& src2 = Operand(zero_reg));
+#endif
 
   // Bind a break target.  If there is no current frame at the binding
   // site, there must be at least one frame reaching via a forward