Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: src/platform-linux.cc

Issue 549079: Support for MIPS in architecture independent files.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/platform-linux.cc
===================================================================
--- src/platform-linux.cc (revision 3220)
+++ src/platform-linux.cc (working copy)
@@ -90,11 +90,14 @@
int OS::ActivationFrameAlignment() {
-#ifdef V8_TARGET_ARCH_ARM
+#ifdef V8_TARGET_ARCH_ARM
// On EABI ARM targets this is required for fp correctness in the
// runtime system.
return 8;
#else
+ #ifdef V8_TARGET_ARCH_MIPS
Søren Thygesen Gjesse 2010/01/19 22:59:12 Combine with #else above to #elif.
Alexandre 2010/01/22 23:08:42 Fixed On 2010/01/19 22:59:12, Søren Gjesse wrote:
+ return 8;
+ #endif
// With gcc 4.4 the tree vectorization optimiser can generate code
// that requires 16 byte alignment such as movdqa on x86.
return 16;
@@ -187,6 +190,9 @@
// which is the architecture of generated code).
#if defined(__arm__) || defined(__thumb__)
asm("bkpt 0");
+#elif defined(__mips__)
+ // The code field of the break instruction is available for use as software parameters.
+ asm("break");
#else
asm("int $3");
#endif
@@ -636,8 +642,8 @@
return false;
}
-
static void ProfilerSignalHandler(int signal, siginfo_t* info, void* context) {
+#ifndef V8_HOST_ARCH_MIPS
USE(info);
if (signal != SIGPROF) return;
if (active_sampler_ == NULL) return;
@@ -668,6 +674,8 @@
sample.sp = mcontext.arm_sp;
sample.fp = mcontext.arm_fp;
#endif
+#elif V8_HOST_ARCH_MIPS
+// TODO Implement this on MIPS.
#endif
if (IsVmThread())
active_sampler_->SampleStack(&sample);
@@ -677,6 +685,7 @@
sample.state = Logger::state();
active_sampler_->Tick(&sample);
+#endif
}

Powered by Google App Engine
This is Rietveld 408576698