Support for MIPS in architecture independent files....

src/assembler.h

Index: src/assembler.h
===================================================================
--- src/assembler.h	(revision 3220)
+++ src/assembler.h	(working copy)
@@ -487,8 +487,10 @@
   return -(1 << (n-1)) <= x && x < (1 << (n-1));
 }
 
+static inline bool is_int8(int x)  { return is_intn(x, 8); }
+static inline bool is_int16(int x)  { return is_intn(x, 16); }
+static inline bool is_int18(int x)  { return is_intn(x, 18); }
 static inline bool is_int24(int x)  { return is_intn(x, 24); }
-static inline bool is_int8(int x)  { return is_intn(x, 8); }
 
 static inline bool is_uintn(int x, int n) {
   return (x & -(1 << n)) == 0;
@@ -500,10 +502,22 @@
 static inline bool is_uint5(int x)  { return is_uintn(x, 5); }
 static inline bool is_uint6(int x)  { return is_uintn(x, 6); }
 static inline bool is_uint8(int x)  { return is_uintn(x, 8); }
+static inline bool is_uint10(int x)  { return is_uintn(x, 10); }
 static inline bool is_uint12(int x)  { return is_uintn(x, 12); }
 static inline bool is_uint16(int x)  { return is_uintn(x, 16); }
 static inline bool is_uint24(int x)  { return is_uintn(x, 24); }
+static inline bool is_uint26(int x)  { return is_uintn(x, 26); }
 
+
+static inline uint16_t NumBitsSet(uint32_t x) {

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

Rename NumBitsSet to NumberOfBitsSet.

How about just returning int?

[Alexandre, 2010/01/22 23:08:42]

Now returning int. The function was renamed to NumberOfBitsSet.
On 2010/01/19 22:59:12, Søren Gjesse wrote:

+  uint32_t num_bits_set = 0;
+  for(int i=0; i<32; i++) {

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

Please add spaces like this:

for (int i = 0; i < 32; i++) {

See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Horizo....

I don't know whether the performance of this function is important, but take a
look at
http://www-graphics.stanford.edu/~seander/bithacks.html#CountBitsSetNaive for
alternatives.

[Alexandre, 2010/01/22 23:08:42]

Style issue fixed. The body function was changed.
On 2010/01/19 22:59:12, Søren Gjesse wrote:

+    if(x & 1<<i) num_bits_set++;

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

Add spaces here like this

if (x & (1 << i)) num_bits_set++;

[Alexandre, 2010/01/22 23:08:42]

Style issue fixed.
On 2010/01/19 22:59:12, Søren Gjesse wrote:

+  }
+  return num_bits_set;
+}
+
+
 } }  // namespace v8::internal
 
 #endif  // V8_ASSEMBLER_H_