Support for MIPS in architecture independent files....

src/jump-target.h

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 95 matching lines @@
   }
 
   // Emit a jump to the target.  There must be a current frame at the
   // jump and there will be no current frame after the jump.
   virtual void Jump();
   virtual void Jump(Result* arg);
 
   // Emit a conditional branch to the target.  There must be a current
   // frame at the branch.  The current frame will fall through to the
   // code after the branch.
+#ifndef V8_TARGET_ARCH_MIPS

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

Like in codegen.h having a platform specific #ifdef in a platform independent
file should be avoided.

[Alexandre, 2010/01/22 23:08:42]

Same comment (see codegen.h). We need this on MIPS.
On 2010/01/19 22:59:12, Søren Gjesse wrote:

   virtual void Branch(Condition cc, Hint hint = no_hint);
   virtual void Branch(Condition cc, Result* arg, Hint hint = no_hint);
+#else
+  virtual void Branch(Condition cc, Hint hint = no_hint, Register src1 = zero_reg, const Operand& src2 = Operand(zero_reg));

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

Long line, see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Line_L....

[Alexandre, 2010/01/22 23:08:42]

Style issue fixed.
On 2010/01/19 22:59:12, Søren Gjesse wrote:

+  virtual void Branch(Condition cc, Result* arg, Hint hint = no_hint, Register src1 = zero_reg, const Operand& src2 = Operand(zero_reg));
+#endif
 
   // Bind a jump target.  If there is no current frame at the binding
   // site, there must be at least one frame reaching via a forward
   // jump.
   virtual void Bind();
   virtual void Bind(Result* arg);
 
   // Emit a call to a jump target.  There must be a current frame at
   // the call.  The frame at the target is the same as the current
   // frame except for an extra return address on top of it.  The frame
@@ skipping 18 matching lines @@
   // jumps to the block.  Set when the jump target is bound, but may
   // or may not be set for forward-only blocks.
   VirtualFrame* entry_frame_;
 
   // The actual entry label of the block.
   Label entry_label_;
 
   // Implementations of Jump, Branch, and Bind with all arguments and
   // return values using the virtual frame.
   void DoJump();
+#ifndef V8_TARGET_ARCH_MIPS

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

See above.

   void DoBranch(Condition cc, Hint hint);
+#else
+  void DoBranch(Condition cc, Hint hint, Register src1 = zero_reg, const Operand& src2 = Operand(zero_reg));

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

See above.

+#endif
   void DoBind();
 
  private:
   static bool compiling_deferred_code_;
 
   // Add a virtual frame reaching this labeled block via a forward jump,
   // and a corresponding merge code label.
   void AddReachingFrame(VirtualFrame* frame);
 
   // Perform initialization required during entry frame computation
@@ skipping 35 matching lines @@
   // overwritten, without deallocating pointed-to virtual frames.
   void CopyTo(BreakTarget* destination);
 
   // Emit a jump to the target.  There must be a current frame at the
   // jump and there will be no current frame after the jump.
   virtual void Jump();
   virtual void Jump(Result* arg);
 
   // Emit a conditional branch to the target.  There must be a current
   // frame at the branch.  The current frame will fall through to the
   // code after the branch.

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

See above.

+#ifndef V8_TARGET_ARCH_MIPS
   virtual void Branch(Condition cc, Hint hint = no_hint);
   virtual void Branch(Condition cc, Result* arg, Hint hint = no_hint);
+#else
+  virtual void Branch(Condition cc, Hint hint = no_hint,
+      Register src1 = zero_reg, const Operand& src2 = Operand(zero_reg));
+  virtual void Branch(Condition cc, Result* arg, Hint hint = no_hint,
+      Register src1 = zero_reg, const Operand& src2 = Operand(zero_reg));
+#endif
 
   // Bind a break target.  If there is no current frame at the binding
   // site, there must be at least one frame reaching via a forward
   // jump.
   virtual void Bind();
   virtual void Bind(Result* arg);
 
   // Setter for expected height.
   void set_expected_height(int expected) { expected_height_ = expected; }
 
@@ skipping 45 matching lines @@
   bool is_shadowing_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(ShadowTarget);
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_JUMP_TARGET_H_