Support for MIPS in architecture independent files....

src/disasm.h

 // Copyright 2007-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 21 matching lines @@
 
 typedef unsigned char byte;
 
 // Interface and default implementation for converting addresses and
 // register-numbers to text.  The default implementation is machine
 // specific.
 class NameConverter {
  public:
   virtual ~NameConverter() {}
   virtual const char* NameOfCPURegister(int reg) const;
+#ifdef V8_TARGET_ARCH_MIPS

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

This #ifdef should not be needed. Platform specific stuff has already spilled
into this file (NameOfXMMRegister). That is not good practice, but not your
fault.

[Alexandre, 2010/01/22 23:08:42]

Updated. We now use this function instead of NameOfCOP1Register.
On 2010/01/19 22:59:12, Søren Gjesse wrote:

+  // Coprocessor registers for MIPS
+  virtual const char* NameOfCOP1Register(int reg) const;
+#endif
   virtual const char* NameOfByteCPURegister(int reg) const;
   virtual const char* NameOfXMMRegister(int reg) const;
   virtual const char* NameOfAddress(byte* addr) const;
   virtual const char* NameOfConstant(byte* addr) const;
   virtual const char* NameInCode(byte* addr) const;
 };
 
 
 // A generic Disassembler interface
 class Disassembler {
@@ skipping 16 matching lines @@
   static void Disassemble(FILE* f, byte* begin, byte* end);
  private:
   const NameConverter& converter_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(Disassembler);
 };
 
 }  // namespace disasm
 
 #endif  // V8_DISASM_H_