Support for MIPS in architecture independent files....

src/codegen.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 67 matching lines @@
 // Types of uncatchable exceptions.
 enum UncatchableExceptionType { OUT_OF_MEMORY, TERMINATION };
 
 
 #if V8_TARGET_ARCH_IA32
 #include "ia32/codegen-ia32.h"
 #elif V8_TARGET_ARCH_X64
 #include "x64/codegen-x64.h"
 #elif V8_TARGET_ARCH_ARM
 #include "arm/codegen-arm.h"
+#elif V8_TARGET_ARCH_MIPS
+#include "mips/codegen-mips.h"
+// Include the declaration of TestMIPSStub
+#include "mips/test-mips.h"
 #else
 #error Unsupported target architecture.
 #endif
 
 #include "register-allocator.h"
 
 namespace v8 {
 namespace internal {
 
 
@@ skipping 41 matching lines @@
 
 #ifdef DEBUG
   void set_comment(const char* comment) { comment_ = comment; }
   const char* comment() const { return comment_; }
 #else
   void set_comment(const char* comment) { }
   const char* comment() const { return ""; }
 #endif
 
   inline void Jump();
+#ifndef V8_TARGET_ARCH_MIPS

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

Having a platform specific #ifdef in a platform independent file should be
avoided.

[Alexandre, 2010/01/22 23:08:42]

This is necessary for MIPS. We don't have a cmp instruction and conditional
execution, but rather conditional branch instructions. I see two ways to get rid
of this but neither is good:
1) Make all architecture use the mips template. Except for mips they would not
use the extra arguments. Not so good...
2) On MIPS always setup the values to be compared in the same registers and pass
some variable saying which condition to test. This would be really inefficient.
On 2010/01/19 22:59:12, Søren Gjesse wrote:

   inline void Branch(Condition cc);
+#else
+  inline void Branch(Condition cc, Register src1 = zero_reg,

[Søren Thygesen Gjesse, 2010/01/19 22:59:12]

Look at
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...
forformatting of parameter list.

[Alexandre, 2010/01/22 23:08:42]

Style issue fixed.
On 2010/01/19 22:59:12, Søren Gjesse wrote:

+                                  const Operand& src2 = Operand(zero_reg));
+#endif
   void BindExit() { masm_->bind(&exit_label_); }
 
   void SaveRegisters();
   void RestoreRegisters();
 
  protected:
   MacroAssembler* masm_;
 
  private:
   // Constants indicating special actions.  They should not be multiples
@@ skipping 257 matching lines @@
     PrintF("ArgumentsAccessStub (type %d)\n", type_);
   }
 #endif
 };
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_CODEGEN_H_