Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 549063002: [turbofan] Fix Projection operator parameter type. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix Projection operator parameter type. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23764

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Fix2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M src/compiler/common-operator.h View 2 chunks +6 lines, -5 lines 0 comments Download
M src/compiler/graph-unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-unittest.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/node.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 3 months ago (2014-09-08 05:52:36 UTC) #2
Sven Panne
lgtm
6 years, 3 months ago (2014-09-08 06:43:05 UTC) #3
Benedikt Meurer
6 years, 3 months ago (2014-09-08 06:49:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 23764 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698