Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 549043005: Fix component build error in GN build. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix component build error in GN build. The shared memory support functions weren't getting exported properly, and the right targets didn't depend on it. This is the last component build failure in the GN build as of now. R=dpranke@chromium.org Committed: https://crrev.com/390e5e853807f684a2250be30039c32dca96d02a Cr-Commit-Position: refs/heads/master@{#294608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
brettw
6 years, 3 months ago (2014-09-11 19:48:19 UTC) #2
Dirk Pranke
lgtm
6 years, 3 months ago (2014-09-11 20:18:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/549043005/1
6 years, 3 months ago (2014-09-11 21:31:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10471)
6 years, 3 months ago (2014-09-11 22:33:13 UTC) #9
brettw
Committed patchset #1 (id:1) to pending queue manually as 75275fd.
6 years, 3 months ago (2014-09-12 17:19:00 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 17:22:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/390e5e853807f684a2250be30039c32dca96d02a
Cr-Commit-Position: refs/heads/master@{#294608}

Powered by Google App Engine
This is Rietveld 408576698