Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: Source/bindings/tests/results/V8TestObjectPython.cpp

Issue 54903014: [EnforceRange] doesn't enforce range of a short (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Extend layout test Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestObjectPython.cpp
diff --git a/Source/bindings/tests/results/V8TestObjectPython.cpp b/Source/bindings/tests/results/V8TestObjectPython.cpp
index ea2b6e294abc5acff2147335c66f2ab8bbd632aa..f2da55e12b42a85a2b4afbe79f07e2a67f6d3542 100644
--- a/Source/bindings/tests/results/V8TestObjectPython.cpp
+++ b/Source/bindings/tests/results/V8TestObjectPython.cpp
@@ -430,7 +430,7 @@ static void shortAttributeAttributeGetterCallback(v8::Local<v8::String>, const v
static void shortAttributeAttributeSetter(v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- V8TRYCATCH_VOID(int, cppValue, toInt32(jsValue));
+ V8TRYCATCH_VOID(int, cppValue, toInt16(jsValue));
imp->setShortAttribute(cppValue);
}
@@ -511,7 +511,7 @@ static void unsignedShortAttributeAttributeGetterCallback(v8::Local<v8::String>,
static void unsignedShortAttributeAttributeSetter(v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- V8TRYCATCH_VOID(unsigned, cppValue, toUInt32(jsValue));
+ V8TRYCATCH_VOID(unsigned, cppValue, toUInt16(jsValue));
imp->setUnsignedShortAttribute(cppValue);
}
@@ -2632,7 +2632,7 @@ static void reflectUnsignedShortAttributeAttributeGetterCallback(v8::Local<v8::S
static void reflectUnsignedShortAttributeAttributeSetter(v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- V8TRYCATCH_VOID(unsigned, cppValue, toUInt32(jsValue));
+ V8TRYCATCH_VOID(unsigned, cppValue, toUInt16(jsValue));
CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
imp->setAttribute(HTMLNames::reflectunsignedshortattributeAttr, cppValue);
}
@@ -3590,7 +3590,7 @@ static void voidMethodShortArgMethod(const v8::FunctionCallbackInfo<v8::Value>&
return;
}
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- V8TRYCATCH_VOID(int, shortArg, toInt32(info[0]));
+ V8TRYCATCH_VOID(int, shortArg, toInt16(info[0]));
imp->voidMethodShortArg(shortArg);
}
@@ -3644,7 +3644,7 @@ static void voidMethodUnsignedShortArgMethod(const v8::FunctionCallbackInfo<v8::
return;
}
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- V8TRYCATCH_VOID(unsigned, unsignedShortArg, toUInt32(info[0]));
+ V8TRYCATCH_VOID(unsigned, unsignedShortArg, toUInt16(info[0]));
imp->voidMethodUnsignedShortArg(unsignedShortArg);
}

Powered by Google App Engine
This is Rietveld 408576698