chrome/browser/extensions/api/management/management_api.cc - Issue 54903011: Add management policy function allowing extensions to be disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 54903011: Add management policy function allowing extensions to be disabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/management/management_api.cc

diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc

index 5119eb8ccef21c217022fdbb8152645110dd76fb..95a4863e613b96cf2cf808f5c2dee8f293c09281 100644

--- a/chrome/browser/extensions/api/management/management_api.cc

+++ b/chrome/browser/extensions/api/management/management_api.cc

@@ -471,7 +471,9 @@ bool ManagementSetEnabledFunction::RunImpl() {

const ManagementPolicy* policy =

ExtensionSystem::Get(GetProfile())->management_policy();

- if (!policy->UserMayModifySettings(extension, NULL)) {

+ if (!policy->UserMayModifySettings(extension, NULL) ||

+ (!params->enabled && policy->MustRemainEnabled(extension, NULL)) ||

+ (params->enabled && policy->MustRemainDisabled(extension, NULL, NULL))) {

error_ = ErrorUtils::FormatErrorMessage(

keys::kUserCantModifyError, extension_id_);

return false;