Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 54903008: Let WebVTTRegions depends_on=VideoTrack and simplify IDL (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, nessy, arv+blink, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@vttregionsrename
Visibility:
Public.

Description

Let WebVTTRegions depends_on=VideoTrack and simplify IDL BUG=313604 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/html/track/VTTRegion.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/VTTRegionList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
acolwell GONE FROM CHROMIUM
lgtm. Adding eseidel@ since this touches IDL.
7 years, 1 month ago (2013-11-01 22:17:00 UTC) #1
eseidel
lgtm
7 years, 1 month ago (2013-11-01 22:19:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/54903008/1
7 years, 1 month ago (2013-11-01 22:19:35 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/html/track/VTTRegion.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
7 years, 1 month ago (2013-11-01 22:19:37 UTC) #4
philipj_slow
Sorry, should have noted that this depends on https://codereview.chromium.org/55653003/ to land first.
7 years, 1 month ago (2013-11-01 22:24:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/54903008/1
7 years, 1 month ago (2013-11-02 04:29:56 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-02 05:43:46 UTC) #7
Message was sent while issue was closed.
Change committed as 161218

Powered by Google App Engine
This is Rietveld 408576698