Gardening: Fix tests failing on Win7(dbg) caused by hitting an assert in FontCache::addSideloadedFo…

Gardening: Fix tests failing on Win7(dbg) caused by hitting an assert in FontCache::addSideloadedFontForTesting

NOTRY=true
TBR=arv@chromium.org,tkent@chromium.org
BUG=None

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181532

[keishi, 2014-09-08 02:16:56]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-09-08 02:17:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/keishi@chromium.org/549013002/1

[commit-bot: I haz the power, 2014-09-08 02:18:29]

Committed patchset #1 (id:1) as 181532

[tkent, 2014-09-08 08:14:52]

https://codereview.chromium.org/549013002/diff/1/Source/platform/fonts/win/Fo...
File Source/platform/fonts/win/FontCacheSkiaWin.cpp (right):

https://codereview.chromium.org/549013002/diff/1/Source/platform/fonts/win/Fo...
Source/platform/fonts/win/FontCacheSkiaWin.cpp:51: if (!typeface)
Do you think null typeface is the culprit of the following assertion?

    void ref() const {
        SkASSERT(fRefCnt > 0);

[keishi, 2014-09-08 08:19:33]

On 2014/09/08 08:14:52, tkent wrote:
>
https://codereview.chromium.org/549013002/diff/1/Source/platform/fonts/win/Fo...
> File Source/platform/fonts/win/FontCacheSkiaWin.cpp (right):
> 
>
https://codereview.chromium.org/549013002/diff/1/Source/platform/fonts/win/Fo...
> Source/platform/fonts/win/FontCacheSkiaWin.cpp:51: if (!typeface)
> Do you think null typeface is the culprit of the following assertion?
> 
>     void ref() const {
>         SkASSERT(fRefCnt > 0);

I reverted this because it didn't work.
I thought it was a null typeface but refIfNotNull checks for null so I was
wrong.
It looks like the input from kRegisterFontFiles is probably related so I've
asked scottmg@ for assistance.