Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 548953002: [Password Manager] Modified to support saving passwords on forms without username fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index 84443fa6dbce3ad02170f5c0ef69a8f32b4ebc49..a02427f9adf68cceaaf1943126df171138efb757 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -226,8 +226,7 @@ bool PasswordFormManager::HasValidPasswordForm() {
// do not contain username_element and password_element values.
if (observed_form_.scheme != PasswordForm::SCHEME_HTML)
return true;
- return !observed_form_.username_element.empty() &&
- (!observed_form_.password_element.empty() ||
+ return (!observed_form_.password_element.empty() ||
vabr (Chromium) 2014/09/24 09:47:44 nit: no need for the outer parentheses
Pritam Nikam 2014/09/24 12:57:55 Done.
!observed_form_.new_password_element.empty());
}

Powered by Google App Engine
This is Rietveld 408576698