components/password_manager/core/browser/password_manager.cc - Issue 548953002: [Password Manager] Modified to support saving passwords on forms without username fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 548953002: [Password Manager] Modified to support saving passwords on forms without username fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unit-tests and fixed lint errors. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_form_manager.cc ('K') | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | components/password_manager/core/browser/password_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index e05dab3878ac5999bb8748d898a43b44507c6458..87d893e16b52497bfda00c3c312f710f97d18b52 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -4,6 +4,8 @@

#include "components/password_manager/core/browser/password_manager.h"

+#include <string>

vabr (Chromium) 2014/09/15 13:01:45 Another change which should have a separate clean-

Pritam Nikam 2014/09/15 15:02:08 Done.

#include "base/command_line.h"

#include "base/metrics/field_trial.h"

#include "base/metrics/histogram.h"

@@ -401,7 +403,8 @@ bool PasswordManager::ShouldPromptUserToSavePassword() const {

return !client_->IsAutomaticPasswordSavingEnabled() &&

provisional_save_manager_->IsNewLogin() &&

!provisional_save_manager_->HasGeneratedPassword() &&

- !provisional_save_manager_->IsPendingCredentialsPublicSuffixMatch();

+ !provisional_save_manager_->IsPendingCredentialsPublicSuffixMatch() &&

+ provisional_save_manager_->HasValidLogin();

vabr (Chromium) 2014/09/15 13:01:45 As explained in the browsertest above, there shoul

Pritam Nikam 2014/09/15 15:02:08 Done.

}

void PasswordManager::OnPasswordFormsRendered(