components/password_manager/core/browser/password_form_manager.cc - Issue 548953002: [Password Manager] Modified to support saving passwords on forms without username fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 548953002: [Password Manager] Modified to support saving passwords on forms without username fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review changes and code refactoring. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/password_manager/core/browser/password_form_manager.h ('k') | components/password_manager/core/browser/password_form_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.cc

diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc

index 84443fa6dbce3ad02170f5c0ef69a8f32b4ebc49..a997303828f499f043c2fec05f1813aecda4435b 100644

--- a/components/password_manager/core/browser/password_form_manager.cc

+++ b/components/password_manager/core/browser/password_form_manager.cc

@@ -226,9 +226,8 @@ bool PasswordFormManager::HasValidPasswordForm() {

// do not contain username_element and password_element values.

if (observed_form_.scheme != PasswordForm::SCHEME_HTML)

return true;

- return !observed_form_.username_element.empty() &&

- (!observed_form_.password_element.empty() ||

- !observed_form_.new_password_element.empty());

+ return !observed_form_.password_element.empty() ||

+ !observed_form_.new_password_element.empty();

}

void PasswordFormManager::ProvisionallySave(