chrome/test/data/password/form_with_only_password_field.html - Issue 548953002: [Password Manager] Modified to support saving passwords on forms without username fields.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/password/form_with_only_password_field.html

Issue 548953002: [Password Manager] Modified to support saving passwords on forms without username fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/password_manager/password_manager_browsertest.cc ('K') | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | components/autofill/content/renderer/password_autofill_agent.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <body>

	3 <div id="contains-form">

	4 <form action="done.html">

	5 <label for="password">Password</label>
	vabr (Chromium) 2014/09/24 09:47:43 nit: Although the name of the file suggest this, c nit: Although the name of the file suggest this, could you please also insert a <!-- comment --> stating that there is on purpose no username field. This is just to make sure somebody does not include one later by mistake. Pritam Nikam 2014/09/24 12:57:55 Done. Show quoted text On 2014/09/24 09:47:43, vabr (Chromium) wrote: > nit: Although the name of the file suggest this, could you please also insert a > <!-- comment --> stating that there is on purpose no username field. This is > just to make sure somebody does not include one later by mistake. Done.
	6 <input type="password" id="password" name="password">

	7 <input type="submit" id="submit-button" value="Click!">

	8 </form>

	9 </div>

	10 </body>

	11 </html>

OLD	NEW