[Password Manager] Modified to support saving passwords on forms without username fields.

components/password_manager/core/browser/password_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <string>

[vabr (Chromium), 2014/09/15 13:01:45]

Also here -- you don't introduce std::string with this change, so please don't
introduce the #include either. If you think this should be done, file a separate
clean-up CL.

[Pritam Nikam, 2014/09/15 15:02:08]

Done.

 #include <vector>
 
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/password_manager/core/browser/mock_password_store.h"
 #include "components/password_manager/core/browser/password_autofill_manager.h"
@@ skipping 152 matching lines @@
     form.username_element = ASCIIToUTF16("EmailField");
     form.password_element = ASCIIToUTF16("PasswdField");
     form.username_value = ASCIIToUTF16("twitter");
     form.password_value = ASCIIToUTF16("password");
     form.password_autocomplete_set = true;
     form.submit_element = ASCIIToUTF16("signIn");
     form.signon_realm = "https://twitter.com";
     return form;
   }
 
+  PasswordForm MakeSimpleFormWithOnlyPasswordField() {

[vabr (Chromium), 2014/09/15 13:01:46]

nit: To improve readability, consider changing the body to these 4 lines:
PasswordForm form(MakeSimpleForm());
form.username_element.clear();
form.username_value.clear();
return form;

(See also MakeFormWithOnlyNewPasswordField().)

[Pritam Nikam, 2014/09/15 15:02:08]

Done.

+    PasswordForm form;
+    form.origin = GURL("http://www.google.com/a/LoginAuth");
+    form.action = GURL("http://www.google.com/a/Login");
+    form.password_element = ASCIIToUTF16("Passwd");
+    form.password_value = ASCIIToUTF16("password");
+    form.password_autocomplete_set = true;
+    form.submit_element = ASCIIToUTF16("signIn");
+    form.signon_realm = "http://www.google.com";
+    return form;
+  }
+
   bool FormsAreEqual(const autofill::PasswordForm& lhs,
                      const autofill::PasswordForm& rhs) {
     if (lhs.origin != rhs.origin)
       return false;
     if (lhs.action != rhs.action)
       return false;
     if (lhs.username_element != rhs.username_element)
       return false;
     if (lhs.password_element != rhs.password_element)
       return false;
@@ skipping 564 matching lines @@
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_)).Times(Exactly(0));
   EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form))).Times(Exactly(0));
 
   // Submit form and finish navigation.
   manager()->ProvisionallySavePassword(form);
   observed.clear();
   manager()->OnPasswordFormsParsed(observed);
   manager()->OnPasswordFormsRendered(observed, true);
 }
 
+TEST_F(PasswordManagerTest, FormSubmitWithOnlyPassowrdField) {
+  // Test that observing a newly submitted form shows the save password bar.

[vabr (Chromium), 2014/09/15 13:01:45]

nits:
(1) Do mention what is special about the form (no username element).
(2) "save password bar" -> "save password prompt" (because the UI is switching
from bars to bubbles, and 'prompt' is more generic)

[Pritam Nikam, 2014/09/15 15:02:09]

Done.

+  std::vector<PasswordForm*> result;  // Empty password store.
+  EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
+  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
+  std::vector<PasswordForm> observed;
+  PasswordForm form(MakeSimpleFormWithOnlyPasswordField());
+  observed.push_back(form);
+  manager()->OnPasswordFormsParsed(observed);          // The initial load.
+  manager()->OnPasswordFormsRendered(observed, true);  // The initial layout.
+
+  // Simulate the user generating the password and submitting the form.

[vabr (Chromium), 2014/09/15 13:01:45]

Don't mix password generation in -- we only allow to save passwords on forms
without usernames, not generate them (yet).

[Pritam Nikam, 2014/09/15 15:02:08]

Done.

+  manager()->SetFormHasGeneratedPassword(form);
+  manager()->ProvisionallySavePassword(form);
+
+  // The user should not be presented with an infobar as they have already given

[vabr (Chromium), 2014/09/15 13:01:46]

This whole comment looks wrong: the save password prompt (not necessarily
infobar) should be shown, there was no generated password and no prior consent,
and no post-saving notification takes place.

[Pritam Nikam, 2014/09/15 15:02:08]

Done.

+  // consent by using the generated password. The form should be saved once
+  // navigation occurs. The client will be informed that automatic saving has
+  // occured.
+  EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_)).Times(Exactly(0));

[vabr (Chromium), 2014/09/15 13:01:46]

Please update the expectations following the clarifications above.

[Pritam Nikam, 2014/09/15 15:02:08]

Done.

+  EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form)));
+  scoped_ptr<PasswordFormManager> saved_form_manager;
+  EXPECT_CALL(client_, AutomaticPasswordSavePtr(_)).Times(Exactly(1)).WillOnce(
+      WithArg<0>(SaveToScopedPtr(&saved_form_manager)));
+
+  // Now the password manager waits for the navigation to complete.
+  observed.clear();
+  manager()->OnPasswordFormsParsed(observed);  // The post-navigation load.
+  manager()->OnPasswordFormsRendered(observed,
+                                     true);  // The post-navigation layout.
+}
+
 }  // namespace password_manager