[Password Manager] Modified to support saving passwords on forms without username fields.

components/password_manager/core/browser/password_form_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/password_form_manager.h"
 
 #include <algorithm>
+#include <set>

[vabr (Chromium), 2014/09/15 13:01:45]

Is this related to your other changes in the CL? If not, don't introduce the
header here. If you feel it should be included, please do a separate clean-up CL
for it.

[Pritam Nikam, 2014/09/15 15:02:08]

Done.

I've changed this to resolve Lint error. Notified pre- git cl upload script
execution.
I'll raise a separate review to do cleanup for the same.

 
 #include "base/metrics/histogram.h"
 #include "base/metrics/user_metrics.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/autofill/core/browser/form_structure.h"
 #include "components/autofill/core/browser/validation.h"
 #include "components/autofill/core/common/password_form.h"
@@ skipping 70 matching lines @@
 PasswordFormManager::~PasswordFormManager() {
   UMA_HISTOGRAM_ENUMERATION(
       "PasswordManager.ActionsTakenV3", GetActionsTaken(), kMaxNumActionsTaken);
   if (has_generated_password_ && submit_result_ == kSubmitResultNotSubmitted)
     LogPasswordGenerationSubmissionEvent(PASSWORD_NOT_SUBMITTED);
 }
 
 int PasswordFormManager::GetActionsTaken() {
   return user_action_ + kUserActionMax * (manager_action_ +
          kManagerActionMax * submit_result_);
-};
+}

[vabr (Chromium), 2014/09/15 13:01:45]

Again, this does not seem related to the rest of the CL. Although the semicolon
is clearly a typo, it should be removed in a separate clean-up CL, not in this
one.

[Pritam Nikam, 2014/09/15 15:02:08]

Done.

Ditto!

 
 // TODO(timsteele): use a hash of some sort in the future?
 PasswordFormManager::MatchResultMask PasswordFormManager::DoesManage(
     const PasswordForm& form) const {
   // Non-HTML form case.
   if (observed_form_.scheme != PasswordForm::SCHEME_HTML ||
       form.scheme != PasswordForm::SCHEME_HTML) {
     const bool forms_match = observed_form_.signon_realm == form.signon_realm &&
                              observed_form_.scheme == form.scheme;
     return forms_match ? RESULT_COMPLETE_MATCH : RESULT_NO_MATCH;
@@ skipping 110 matching lines @@
   // has already given consent, so we treat these cases the same.
   return has_generated_password_;
 }
 
 bool PasswordFormManager::HasValidPasswordForm() {
   DCHECK_EQ(state_, POST_MATCHING_PHASE);
   // Non-HTML password forms (primarily HTTP and FTP autentication)
   // do not contain username_element and password_element values.
   if (observed_form_.scheme != PasswordForm::SCHEME_HTML)
     return true;
-  return !observed_form_.username_element.empty() &&
-         (!observed_form_.password_element.empty() ||
+  return (!observed_form_.password_element.empty() ||
           !observed_form_.new_password_element.empty());
 }
 
+bool PasswordFormManager::HasValidLogin() {
+  return !observed_form_.username_element.empty();
+}
+
 void PasswordFormManager::ProvisionallySave(
     const PasswordForm& credentials,
     OtherPossibleUsernamesAction action) {
   DCHECK_EQ(state_, POST_MATCHING_PHASE);
   DCHECK_NE(RESULT_NO_MATCH, DoesManage(credentials));
 
   // If this was a sign-up or change password form, we want to persist the new
   // password; if this was a login form, then the current password (which might
   // still be "new" in the sense that we see these credentials for the first
   // time, or that the user manually entered his actual password to overwrite an
@@ skipping 529 matching lines @@
     LogPasswordGenerationSubmissionEvent(PASSWORD_SUBMITTED);
 }
 
 void PasswordFormManager::SubmitFailed() {
   submit_result_ = kSubmitResultFailed;
   if (has_generated_password_)
     LogPasswordGenerationSubmissionEvent(PASSWORD_SUBMISSION_FAILED);
 }
 
 }  // namespace password_manager