Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: chrome/browser/content_settings/permission_context_uma_util.cc

Issue 548843003: Fix a typo in the name of the ContentSettings.Permis(s)ionActions histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/metrics/histogram.h" 5 #include "base/metrics/histogram.h"
6 #include "chrome/browser/content_settings/permission_context_uma_util.h" 6 #include "chrome/browser/content_settings/permission_context_uma_util.h"
7 7
8 namespace { 8 namespace {
9 9
10 // Enum for UMA purposes, make sure you update histograms.xml if you add new 10 // Enum for UMA purposes, make sure you update histograms.xml if you add new
(...skipping 24 matching lines...) Expand all
35 35
36 void RecordPermissionAction( 36 void RecordPermissionAction(
37 ContentSettingsType permission, PermissionAction action) { 37 ContentSettingsType permission, PermissionAction action) {
38 switch (permission) { 38 switch (permission) {
39 case CONTENT_SETTINGS_TYPE_GEOLOCATION: 39 case CONTENT_SETTINGS_TYPE_GEOLOCATION:
40 // TODO(miguelg): support geolocation through 40 // TODO(miguelg): support geolocation through
41 // the generic permission class. 41 // the generic permission class.
42 break; 42 break;
43 case CONTENT_SETTINGS_TYPE_NOTIFICATIONS: 43 case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
44 UMA_HISTOGRAM_ENUMERATION( 44 UMA_HISTOGRAM_ENUMERATION(
45 "ContentSettings.PermisionActions_Notifications", 45 "ContentSettings.PermissionActions_Notifications",
46 action, 46 action,
47 PERMISSION_ACTION_NUM); 47 PERMISSION_ACTION_NUM);
48 break; 48 break;
49 case CONTENT_SETTINGS_TYPE_MIDI_SYSEX: 49 case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
50 UMA_HISTOGRAM_ENUMERATION("ContentSettings.PermisionActions_MidiSysEx", 50 UMA_HISTOGRAM_ENUMERATION("ContentSettings.PermissionActions_MidiSysEx",
51 action, 51 action,
52 PERMISSION_ACTION_NUM); 52 PERMISSION_ACTION_NUM);
53 break; 53 break;
54 case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING: 54 case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
55 UMA_HISTOGRAM_ENUMERATION( 55 UMA_HISTOGRAM_ENUMERATION(
56 "ContentSettings.PermisionActions_PushMessaging", 56 "ContentSettings.PermissionActions_PushMessaging",
57 action, 57 action,
58 PERMISSION_ACTION_NUM); 58 PERMISSION_ACTION_NUM);
59 break; 59 break;
60 #if defined(OS_ANDROID) 60 #if defined(OS_ANDROID)
61 case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER: 61 case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
62 // TODO(miguelg): support protected media through 62 // TODO(miguelg): support protected media through
63 // the generic permission class. 63 // the generic permission class.
64 break; 64 break;
65 #endif 65 #endif
66 default: 66 default:
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 110
111 void PermissionContextUmaUtil::PermissionDismissed( 111 void PermissionContextUmaUtil::PermissionDismissed(
112 ContentSettingsType permission) { 112 ContentSettingsType permission) {
113 RecordPermissionAction(permission, DISMISSED); 113 RecordPermissionAction(permission, DISMISSED);
114 } 114 }
115 115
116 void PermissionContextUmaUtil::PermissionIgnored( 116 void PermissionContextUmaUtil::PermissionIgnored(
117 ContentSettingsType permission) { 117 ContentSettingsType permission) {
118 RecordPermissionAction(permission, IGNORED); 118 RecordPermissionAction(permission, IGNORED);
119 } 119 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698