Issue 54883002: Fix more warnings.

Issue 54883002: Fix more warnings. (Closed)

Created:
7 years, 1 month ago by lgombos

Modified:
7 years, 1 month ago

Reviewers:
Nico

CC:
blink-reviews, yurys+blink_chromium.org, loislo+blink_chromium.org, adamk+blink_chromium.org, abarth-chromium, Chris Evans

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix more warnings. BUG=312287 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161069

Patch Set 1 #

Total comments: 3

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	Source/testing/runner/EventSender.cpp	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	Source/wtf/PageAllocator.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/wtf/QuantizedAllocation.cpp	View	1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://codereview.chromium.org/54883002/diff/1/Source/testing/runner/EventSender.cpp File Source/testing/runner/EventSender.cpp (right): https://codereview.chromium.org/54883002/diff/1/Source/testing/runner/EventSender.cpp#newcode259 Source/testing/runner/EventSender.cpp:259: , m_delegate(0) Huh, do you know why the ...

7 years, 1 month ago (2013-10-31 15:40:59 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/54883002/1

7 years, 1 month ago (2013-10-31 15:57:51 UTC) #3

lgombos

7 years, 1 month ago (2013-10-31 19:10:11 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/54883002/diff/1/Source/testing/runner/EventSe...
File Source/testing/runner/EventSender.cpp (right):

https://codereview.chromium.org/54883002/diff/1/Source/testing/runner/EventSe...
Source/testing/runner/EventSender.cpp:259: , m_delegate(0)
On 2013/10/31 15:40:59, Nico wrote:
> Huh, do you know why the mac waterfall bots don't complain about this? Do they
> not build the TestRunner target?

The answer - https://codereview.chromium.org/51413003/

Expand Messages | Collapse Messages