Issue 548713002: Fix v8's GN v86 build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 548713002: Fix v8's GN v86 build. (Closed)

Created:
6 years, 3 months ago by brettw

Modified:
6 years, 3 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/external/v8.git@master

Project:
v8

Visibility:
Public.

Fix v8's GN v86 build. This got out-of-sync with some GYP changes. Also makes it compile on Windows. R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23770

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	BUILD.gn	View		2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

jochen (gone - plz use gerrit)

Committed patchset #1 (id:1) manually as 23770 (presubmit successful).

6 years, 3 months ago (2014-09-08 10:48:39 UTC) #3

brettw

6 years, 3 months ago (2014-09-08 16:09:59 UTC) #4

Message was sent while issue was closed.

On 2014/09/08 10:48:39, jochen wrote:
> Committed patchset #1 (id:1) manually as 23770 (presubmit successful).

Thanks for committing.