Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 548703003: Mark HID and USB device connections as non-persistent API resources. (Closed)

Created:
6 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mark HID and USB device connections as non-persistent API resources. Add an IsPersistent function to mark these resources as non-persistent so that they will be cleaned up when the extension is suspended. The default is persistent. BUG=397234, 409759 Committed: https://crrev.com/8e6fae0b21680e56793dde769bdc36daca8880bb Cr-Commit-Position: refs/heads/master@{#293626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -17 lines) Patch
M extensions/browser/api/hid/hid_api.h View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/browser/api/hid/hid_connection_resource.h View 2 chunks +9 lines, -3 lines 0 comments Download
M extensions/browser/api/hid/hid_connection_resource.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/api/usb/usb_device_resource.h View 1 chunk +7 lines, -8 lines 0 comments Download
M extensions/browser/api/usb/usb_device_resource.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Reilly Grant (use Gerrit)
6 years, 3 months ago (2014-09-05 23:37:25 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-05 23:40:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/548703003/1
6 years, 3 months ago (2014-09-06 00:02:14 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 11:36:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/548703003/1
6 years, 3 months ago (2014-09-06 17:04:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0d36c21adfd31d4bcd3665e6b0aea338b7601872
6 years, 3 months ago (2014-09-06 18:57:32 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:43:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e6fae0b21680e56793dde769bdc36daca8880bb
Cr-Commit-Position: refs/heads/master@{#293626}

Powered by Google App Engine
This is Rietveld 408576698