Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller.cc

Issue 548703002: Fixes possible crash in tab dragging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/tab_drag_controller.cc
diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.cc b/chrome/browser/ui/views/tabs/tab_drag_controller.cc
index 2ef2d96cc422aa56ed94edbfd9a74a38291a343d..b6dbafc92a3c24255bfb39d9aed7986d40db65d2 100644
--- a/chrome/browser/ui/views/tabs/tab_drag_controller.cc
+++ b/chrome/browser/ui/views/tabs/tab_drag_controller.cc
@@ -1358,7 +1358,8 @@ void TabDragController::EndDragImpl(EndDragType type) {
}
} else if (drag_data_.size() > 1) {
initial_selection_model_.Clear();
- RevertDrag();
+ if (started_drag_)
+ RevertDrag();
} // else case the only tab we were dragging was deleted. Nothing to do.
// Clear out drag data so we don't attempt to do anything with it.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698