Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 548703002: Fixes possible crash in tab dragging (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tfarina, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixes possible crash in tab dragging This crash would happen if you select a couple of tabs, then click but don't drag and hit escape or control-w. The crash would occur because we would end up inserting the tabs a second time even though they are already in the tabstrip. BUG=360822 TEST=see bug R=ben@chromium.org Committed: https://crrev.com/7a27d4d62877348f8e172c4a432cc54c0a969c02 Cr-Commit-Position: refs/heads/master@{#293625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
sky
Sure would be nice to have test coverage, but that proves painful for many different ...
6 years, 3 months ago (2014-09-05 23:11:49 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 3 months ago (2014-09-05 23:12:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/548703002/1
6 years, 3 months ago (2014-09-05 23:14:34 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/5970)
6 years, 3 months ago (2014-09-06 01:28:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/548703002/1
6 years, 3 months ago (2014-09-06 02:31:43 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 11:18:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/548703002/1
6 years, 3 months ago (2014-09-06 15:11:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 153da9bac982a0a7fd551b13372465b0a10562c5
6 years, 3 months ago (2014-09-06 18:56:02 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:58 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a27d4d62877348f8e172c4a432cc54c0a969c02
Cr-Commit-Position: refs/heads/master@{#293625}

Powered by Google App Engine
This is Rietveld 408576698