Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 548693002: Share recalcChildStyle between Element and ShadowRoot. (Closed)

Created:
6 years, 3 months ago by esprehn
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Project:
blink
Visibility:
Public.

Description

Share recalcChildStyle between Element and ShadowRoot. Instead of needing to update both loops any time we change anything we should just put the Element specific things in Element::recalcStyle and then put the shared method into ContainerNode. I also removed an old comment about ShadowRoot::recalcStyle not supporting adjacent selectors properly (I fixed that bug a long time ago). There should be no change in behavior, I just moved the code around. BUG=399816 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181500

Patch Set 1 #

Patch Set 2 : merge blocks. #

Patch Set 3 : Remove code from my other branch for whitespace. #

Patch Set 4 : Remove code from other branch. #

Patch Set 5 : Add back parent scope for ShadowRoot. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -66 lines) Patch
M Source/core/dom/ContainerNode.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 2 chunks +15 lines, -48 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 1 2 3 4 1 chunk +1 line, -17 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
esprehn
6 years, 3 months ago (2014-09-05 23:58:22 UTC) #2
leviw_travelin_and_unemployed
Cool, makes sense. LGTM.
6 years, 3 months ago (2014-09-06 00:03:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/548693002/80001
6 years, 3 months ago (2014-09-06 00:09:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/25850)
6 years, 3 months ago (2014-09-06 02:09:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/548693002/80001
6 years, 3 months ago (2014-09-06 02:17:23 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 12:22:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/548693002/80001
6 years, 3 months ago (2014-09-06 16:37:14 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-06 16:37:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as 181500

Powered by Google App Engine
This is Rietveld 408576698