Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 548683002: Update the timezone list to show in the UI (Closed)

Created:
6 years, 3 months ago by jungshik at Google
Modified:
6 years, 3 months ago
Reviewers:
Nikita (slow), oshima
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update the timezone list to show in the UI On Oct 26, 2014, Russia will switch from 9 timezones to 11 timezones with most of the current zones going back by an hour from the current zone. (e.g. Europe/Moscow will be UTC+0300 instead of UTC+0400). Add new Russian time zones and shuffle the timezone order in the tz selection UI to make them roughly in the order of their tz offsets when the change gets effective on Oct 26, 2014. In the meantime, some zones will be out-of-place. This ordering can't be perfect beause of DST. To address that issue, this CL will be followed by a CL to sort them dynamically instead of using the hardcoded order. BUG=404445 TEST=Go to settings - advanced - timezone setting and look for Asia/Kamchatka. Committed: https://crrev.com/2c2205314571fdefe40521e08e9b1741ca9415ae Cr-Commit-Position: refs/heads/master@{#294458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M chromeos/settings/timezone_settings.cc View 4 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jungshik at Google
6 years, 3 months ago (2014-09-05 22:49:13 UTC) #2
Nikita (slow)
lgtm
6 years, 3 months ago (2014-09-10 16:04:46 UTC) #3
jungshik at Google
oshima@chromium.org: Can you approve? Thanks
6 years, 3 months ago (2014-09-10 18:55:59 UTC) #5
oshima
lgtm
6 years, 3 months ago (2014-09-10 19:20:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/548683002/1
6 years, 3 months ago (2014-09-11 19:09:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2dac3fc4663b87365da94176d6d230a33c3e7597
6 years, 3 months ago (2014-09-11 20:30:30 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 20:42:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c2205314571fdefe40521e08e9b1741ca9415ae
Cr-Commit-Position: refs/heads/master@{#294458}

Powered by Google App Engine
This is Rietveld 408576698