Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 548653002: Move ErrorMapUnitTest to extensions_unittests (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move ErrorMapUnitTest to extensions_unittests It doesn't need to run as part of Chrome's unit_tests BUG=397164 TEST=extensions_unittests Committed: https://crrev.com/57b0f8576e52002b6f51f27e0f388c5f15795854 Cr-Commit-Position: refs/heads/master@{#293670}

Patch Set 1 #

Patch Set 2 : (error-map) rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/extensions.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
James Cook
rockot, PTAL
6 years, 3 months ago (2014-09-05 20:20:09 UTC) #2
Ken Rockot(use gerrit already)
Nice. That was easy. lgtm
6 years, 3 months ago (2014-09-05 20:39:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/548653002/1
6 years, 3 months ago (2014-09-05 20:57:13 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 03:08:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/548653002/1
6 years, 3 months ago (2014-09-07 00:07:52 UTC) #9
commit-bot: I haz the power
Failed to apply patch for chrome/chrome_tests_unit.gypi: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-07 00:09:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/548653002/20001
6 years, 3 months ago (2014-09-07 21:50:48 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 184613172431e7f14aa95cdd4c46f9ac19409c8b
6 years, 3 months ago (2014-09-07 23:38:03 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:44:29 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57b0f8576e52002b6f51f27e0f388c5f15795854
Cr-Commit-Position: refs/heads/master@{#293670}

Powered by Google App Engine
This is Rietveld 408576698