Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 548633004: Hook up the link pool in the GN build. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Hook up the link pool in the GN build. This uses the code from GYP to compute the maximum number of concurrent links to use in the link pool, and sets this value in the toolchains. Committed: https://crrev.com/937a6d51df85cd7e338b952aeacb03bf7e5726c2 Cr-Commit-Position: refs/heads/master@{#294007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M build/toolchain/gcc_toolchain.gni View 1 chunk +3 lines, -0 lines 0 comments Download
A build/toolchain/get_concurrent_links.py View 1 chunk +64 lines, -0 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
brettw
6 years, 3 months ago (2014-09-09 17:15:58 UTC) #2
scottmg
Is this to fix something? It mostly sucked in gyp, so I'm not sure it's ...
6 years, 3 months ago (2014-09-09 18:04:48 UTC) #3
scottmg
On 2014/09/09 18:04:48, scottmg wrote: > Is this to fix something? It mostly sucked in ...
6 years, 3 months ago (2014-09-09 19:37:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/548633004/1
6 years, 3 months ago (2014-09-09 19:58:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as f8f8574fbe6ac7691a870196b3584bb5cb9bcdd0
6 years, 3 months ago (2014-09-09 20:58:08 UTC) #7
Nico
On 2014/09/09 19:37:51, scottmg wrote: > On 2014/09/09 18:04:48, scottmg wrote: > > Is this ...
6 years, 3 months ago (2014-09-09 21:04:25 UTC) #8
brettw
We added this originally in GYP/Ninja because it would sometimes lock up your machine toward ...
6 years, 3 months ago (2014-09-09 21:11:27 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:55:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/937a6d51df85cd7e338b952aeacb03bf7e5726c2
Cr-Commit-Position: refs/heads/master@{#294007}

Powered by Google App Engine
This is Rietveld 408576698