Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: content/browser/renderer_host/media/media_stream_manager.h

Issue 54863002: Implement a salt for MediaSource IDs that can be cleared by a user. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed jois nit. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/media_stream_manager.h
diff --git a/content/browser/renderer_host/media/media_stream_manager.h b/content/browser/renderer_host/media/media_stream_manager.h
index 4df8957b24c7a3ace306669bb77ffcb1b81d7736..6a718dba15fb718c6335f9732933dbbef7e13fe8 100644
--- a/content/browser/renderer_host/media/media_stream_manager.h
+++ b/content/browser/renderer_host/media/media_stream_manager.h
@@ -51,6 +51,7 @@ class FakeMediaStreamUIProxy;
class MediaStreamDeviceSettings;
class MediaStreamRequester;
class MediaStreamUIProxy;
+class ResourceContext;
class VideoCaptureManager;
// MediaStreamManager is used to generate and close new media devices, not to
@@ -96,6 +97,7 @@ class CONTENT_EXPORT MediaStreamManager
std::string GenerateStream(MediaStreamRequester* requester,
int render_process_id,
int render_view_id,
+ ResourceContext* rc,
int page_request_id,
const StreamOptions& components,
const GURL& security_origin);
@@ -119,6 +121,7 @@ class CONTENT_EXPORT MediaStreamManager
virtual std::string EnumerateDevices(MediaStreamRequester* requester,
int render_process_id,
int render_view_id,
+ ResourceContext* rc,
int page_request_id,
MediaStreamType type,
const GURL& security_origin);
@@ -129,6 +132,7 @@ class CONTENT_EXPORT MediaStreamManager
std::string OpenDevice(MediaStreamRequester* requester,
int render_process_id,
int render_view_id,
+ ResourceContext* rc,
int page_request_id,
const std::string& device_id,
MediaStreamType type,
@@ -234,17 +238,15 @@ class CONTENT_EXPORT MediaStreamManager
// needed. If a certain source id has been requested, the source id is
// translated to a real device id before the request is posted to UI.
void PostRequestToUI(const std::string& label, DeviceRequest* request);
- // Returns true if a device with |device_id| has already been requested by
- // |render_process_id| and |render_view_id| of type |type|. If it has been
- // requested, |device_info| contain information about the device.
- bool FindExistingRequestedDeviceInfo(int render_process_id,
- int render_view_id,
- const GURL& security_origin,
- MediaStreamRequestType type,
- const std::string& device_id,
- MediaStreamType device_type,
- StreamDeviceInfo* device_info,
- MediaRequestState* request_state) const;
+ // Returns true if a device with |device_id| has already been requested with
+ // a render procecss_id and render_view_id and type equal to the the values
+ // in |request|. If it has been requested, |device_info| contain information
+ // about the device.
+ bool FindExistingRequestedDeviceInfo(
+ const DeviceRequest& new_request,
+ const MediaStreamDevice& new_device_info,
+ StreamDeviceInfo* existing_device_info,
+ MediaRequestState* existing_request_state) const;
void FinalizeGenerateStream(const std::string& label,
DeviceRequest* request);
@@ -273,8 +275,8 @@ class CONTENT_EXPORT MediaStreamManager
void StartMonitoring();
void StopMonitoring();
- bool TranslateRequestedSourceIdToDeviceId(MediaStreamRequest* request);
- void TranslateDeviceIdToSourceId(const MediaStreamRequest& request,
+ bool TranslateRequestedSourceIdToDeviceId(DeviceRequest* request);
+ void TranslateDeviceIdToSourceId(DeviceRequest* request,
MediaStreamDevice* device);
// Finds and returns the device id corresponding to the given
@@ -282,6 +284,7 @@ class CONTENT_EXPORT MediaStreamManager
// given |source_id|, false if nothing matched it.
bool TranslateSourceIdToDeviceId(
MediaStreamType stream_type,
+ ResourceContext* rc,
const GURL& security_origin,
const std::string& source_id,
std::string* device_id);

Powered by Google App Engine
This is Rietveld 408576698