Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: pkg/analysis_server/lib/src/edit/edit_domain.dart

Issue 548593002: Integrate 'Rename' refactoring into Editor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/edit/edit_domain.dart
diff --git a/pkg/analysis_server/lib/src/edit/edit_domain.dart b/pkg/analysis_server/lib/src/edit/edit_domain.dart
index 0dae7925921fdedbd92add6e05ccd3dd2de2d395..2c28a41189b068e6f2a943891cc19b86398eebd5 100644
--- a/pkg/analysis_server/lib/src/edit/edit_domain.dart
+++ b/pkg/analysis_server/lib/src/edit/edit_domain.dart
@@ -202,12 +202,13 @@ class _RefactoringManager {
// process the request
var params = new EditGetRefactoringParams.fromRequest(request);
_init(params.kind, params.file, params.offset, params.length).then((_) {
- if (_hasFatalError) {
+ if (initStatus.hasFatalError) {
return _sendResultResponse();
}
// set options
if (_requiresOptions) {
if (params.options == null) {
+ optionsStatus = new RefactoringStatus();
return _sendResultResponse();
}
optionsStatus = _setOptions(params);
@@ -217,6 +218,7 @@ class _RefactoringManager {
}
// done if just validation
if (params.validateOnly) {
+ finalStatus = new RefactoringStatus();
return _sendResultResponse();
}
// validation and create change

Powered by Google App Engine
This is Rietveld 408576698