Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: gclient_scm.py

Issue 548553003: Make check for dirty index work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: lint Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/gclient_scm_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_scm.py
diff --git a/gclient_scm.py b/gclient_scm.py
index 439bc6b116b5bdc1d73f6bc78e8c89bec2892703..8236282af161639ee6d4e194c63dce29f8c4043d 100644
--- a/gclient_scm.py
+++ b/gclient_scm.py
@@ -589,9 +589,10 @@ class GitWrapper(SCMWrapper):
return
else:
self.Print('Input not recognized')
- elif re.match("error: Your local changes to '.*' would be "
- "overwritten by merge. Aborting.\nPlease, commit your "
- "changes or stash them before you can merge.\n",
+ elif re.match("error: Your local changes to (')?.*(')? would be "
+ "overwritten by merge(. Aborting)?[:.]\n(.*\n)?Please, "
+ "commit your changes or stash them before you can "
+ "merge.\n",
e.stderr):
if not printed_path:
self.Print('_____ %s%s' % (self.relpath, rev_str), timestamp=False)
@@ -997,7 +998,7 @@ class GitWrapper(SCMWrapper):
% (self.relpath, rev_str))
try:
scm.GIT.Capture(['diff-index', '--cached', '--name-status', '-r',
- '--ignore-submodules', 'HEAD', '--'],
+ '--ignore-submodules', '--exit-code', 'HEAD', '--'],
cwd=self.checkout_path)
except subprocess2.CalledProcessError:
raise gclient_utils.Error('\n____ %s%s\n'
« no previous file with comments | « no previous file | tests/gclient_scm_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698