Issue 548553003: Make check for dirty index work.

Issue 548553003: Make check for dirty index work. (Closed)

Created:
6 years, 3 months ago by Michael Moss

Modified:
6 years, 3 months ago

Reviewers:
agable, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Project:
tools

Visibility:
Public.

Make check for dirty index work. Without --exit-code, diff-index always returns 0 and thus never throws the exception for a dirty index. R=iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291881

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -12 lines)			Patch
	M	gclient_scm.py	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
	M	tests/gclient_scm_test.py	View	1 2	3 chunks	+40 lines, -8 lines	0 comments	Download

Total messages: 8 (2 generated)

agable

lgtm, nice catch. Can't believe this has been broken for so long with no complaints...

6 years, 3 months ago (2014-09-09 14:32:10 UTC) #3

Michael Moss

On 2014/09/09 14:32:10, agable wrote: > lgtm, nice catch. Can't believe this has been broken ...

6 years, 3 months ago (2014-09-09 16:20:04 UTC) #4

agable

On 2014/09/09 16:20:04, Michael Moss wrote: > On 2014/09/09 14:32:10, agable wrote: > > lgtm, ...

6 years, 3 months ago (2014-09-09 16:52:14 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmoss@chromium.org/548553003/40001

6 years, 3 months ago (2014-09-09 16:55:34 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-09 16:57:28 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as 291881