Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: sync/internal_api/attachments/attachment_service_proxy.cc

Issue 548533003: Replace AttachmentStore's StoreAttachments with UploadAttachments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call get() on scoped_refptr. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/attachments/attachment_service_proxy.cc
diff --git a/sync/internal_api/attachments/attachment_service_proxy.cc b/sync/internal_api/attachments/attachment_service_proxy.cc
index 1d418788e11ffdf71c1115484a2f0d7e8b1ae24f..6b1040bafdf3a0aa6cbe5b367384b958a3d76057 100644
--- a/sync/internal_api/attachments/attachment_service_proxy.cc
+++ b/sync/internal_api/attachments/attachment_service_proxy.cc
@@ -35,15 +35,6 @@ void ProxyDropCallback(
task_runner->PostTask(FROM_HERE, base::Bind(callback, result));
}
-// Invokes |callback| with |result| and |attachments| in the |task_runner|
-// thread.
-void ProxyStoreCallback(
- const scoped_refptr<base::SequencedTaskRunner>& task_runner,
- const AttachmentService::StoreCallback& callback,
- const AttachmentService::StoreResult& result) {
- task_runner->PostTask(FROM_HERE, base::Bind(callback, result));
-}
-
} // namespace
AttachmentServiceProxy::AttachmentServiceProxy() {
@@ -67,6 +58,10 @@ AttachmentServiceProxy::AttachmentServiceProxy(
AttachmentServiceProxy::~AttachmentServiceProxy() {
}
+AttachmentStore* AttachmentServiceProxy::GetStore() {
+ return NULL;
+}
+
void AttachmentServiceProxy::GetOrDownloadAttachments(
const AttachmentIdList& attachment_ids,
const GetOrDownloadCallback& callback) {
@@ -96,17 +91,12 @@ void AttachmentServiceProxy::DropAttachments(
proxy_callback));
}
-void AttachmentServiceProxy::StoreAttachments(const AttachmentList& attachments,
- const StoreCallback& callback) {
+void AttachmentServiceProxy::UploadAttachments(
+ const AttachmentIdSet& attachment_ids) {
DCHECK(wrapped_task_runner_.get());
- StoreCallback proxy_callback = base::Bind(
- &ProxyStoreCallback, base::ThreadTaskRunnerHandle::Get(), callback);
wrapped_task_runner_->PostTask(
FROM_HERE,
- base::Bind(&AttachmentService::StoreAttachments,
- core_,
- attachments,
- proxy_callback));
+ base::Bind(&AttachmentService::UploadAttachments, core_, attachment_ids));
}
AttachmentServiceProxy::Core::Core(
@@ -117,6 +107,10 @@ AttachmentServiceProxy::Core::Core(
AttachmentServiceProxy::Core::~Core() {
}
+AttachmentStore* AttachmentServiceProxy::Core::GetStore() {
+ return NULL;
+}
+
void AttachmentServiceProxy::Core::GetOrDownloadAttachments(
const AttachmentIdList& attachment_ids,
const GetOrDownloadCallback& callback) {
@@ -135,13 +129,12 @@ void AttachmentServiceProxy::Core::DropAttachments(
wrapped_->DropAttachments(attachment_ids, callback);
}
-void AttachmentServiceProxy::Core::StoreAttachments(
- const AttachmentList& attachments,
- const StoreCallback& callback) {
+void AttachmentServiceProxy::Core::UploadAttachments(
+ const AttachmentIdSet& attachment_ids) {
if (!wrapped_) {
return;
}
- wrapped_->StoreAttachments(attachments, callback);
+ wrapped_->UploadAttachments(attachment_ids);
}
} // namespace syncer

Powered by Google App Engine
This is Rietveld 408576698