Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 548533002: Make ServiceWorkerCacheStorage::CacheLoader::LoadCache synchronous (Closed)

Created:
6 years, 3 months ago by jkarlin
Modified:
6 years, 3 months ago
Reviewers:
michaeln
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@no_pointers_keys
Project:
chromium
Visibility:
Public.

Description

Make ServiceWorkerCacheStorage::CacheLoader::LoadCache synchronous The CacheLoader has two functions for creating a cache: 1. LoadCache -- mkdir the cache directory and load the cache into memory 2. CreateCache -- rm -rf the directory and then call LoadCache This CL: 1. Makes LoadCache synchronous by moving the mkdir to CreateCache (in case of loading an existing cache the mkdir was unnecessary) 2. Deletes a bunch of async code 3. Renames LoadCache to CreateServiceWorkerCache Related CLs: 1. https://crrev.com/542703002: Change ownership of the parameters to ServiceWorkerCache:: Put and Match. 2. https://crrev.com/545533002: Move ServiceWorkerCache backend creation to a lazy init function. * 3. https://crrev.com/548533002: Make ServiceWorkerCacheStorage::CacheLoader::LoadCache synchronous 4. https://crrev.com/549493002: Expose ServiceWorkerCache objects to ServiceWorkerCacheStorageManager clients. BUG=392621 Committed: https://crrev.com/43027f011bbc299acd7c4b67a9307ac9512e1df3 Cr-Commit-Position: refs/heads/master@{#294377}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Update comment and remove NULL check that can now only happen if out of memory #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -128 lines) Patch
M content/browser/service_worker/service_worker_cache_storage.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage.cc View 1 2 3 4 6 chunks +42 lines, -121 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jkarlin
Please take a look at everything, thanks!
6 years, 3 months ago (2014-09-05 16:09:52 UTC) #2
michaeln
lgtm https://codereview.chromium.org/548533002/diff/1/content/browser/service_worker/service_worker_cache_storage.cc File content/browser/service_worker/service_worker_cache_storage.cc (right): https://codereview.chromium.org/548533002/diff/1/content/browser/service_worker/service_worker_cache_storage.cc#newcode61 content/browser/service_worker/service_worker_cache_storage.cc:61: // doesn't exist a new one is created. ...
6 years, 3 months ago (2014-09-09 03:27:44 UTC) #3
jkarlin
https://codereview.chromium.org/548533002/diff/1/content/browser/service_worker/service_worker_cache_storage.cc File content/browser/service_worker/service_worker_cache_storage.cc (right): https://codereview.chromium.org/548533002/diff/1/content/browser/service_worker/service_worker_cache_storage.cc#newcode61 content/browser/service_worker/service_worker_cache_storage.cc:61: // doesn't exist a new one is created. On ...
6 years, 3 months ago (2014-09-09 19:18:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/548533002/80001
6 years, 3 months ago (2014-09-11 11:57:04 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 3b0e5301549d81d14344678be6f220ff0ffd8dc6
6 years, 3 months ago (2014-09-11 13:13:45 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 13:17:07 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/43027f011bbc299acd7c4b67a9307ac9512e1df3
Cr-Commit-Position: refs/heads/master@{#294377}

Powered by Google App Engine
This is Rietveld 408576698