Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 548513002: android_webview: stop using system libjpeg. (Closed)

Created:
6 years, 3 months ago by Torne
Modified:
6 years, 3 months ago
Reviewers:
brettw, benm (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

android_webview: stop using system libjpeg. To support unbundled updates we need to stop depending on system libraries. Disable using the system version of libjpeg and instead link Chromium's libjpeg_turbo. This increases binary size by ~120KB. BUG=409851 Committed: https://crrev.com/7c8c58068cdf2997d338cd0b6e3109c5f773dbe6 Cr-Commit-Position: refs/heads/master@{#293663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M android_webview/buildbot/deps_whitelist.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjpeg/libjpeg.gyp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Torne
6 years, 3 months ago (2014-09-05 13:30:15 UTC) #2
Torne
+brettw for libjpeg gyp/gn changes
6 years, 3 months ago (2014-09-05 14:22:00 UTC) #4
benm (inactive)
lgtm
6 years, 3 months ago (2014-09-05 14:27:20 UTC) #5
brettw
lgtm
6 years, 3 months ago (2014-09-05 23:25:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/548513002/1
6 years, 3 months ago (2014-09-06 09:16:56 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 13:49:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/548513002/1
6 years, 3 months ago (2014-09-07 12:40:32 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 13a7d8ea22caccd3d98e37d6424a3e78805b1ccf
6 years, 3 months ago (2014-09-07 12:41:56 UTC) #13
Noel Gordon
120k _and_ 2x-3x faster.
6 years, 3 months ago (2014-09-07 13:07:41 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:44:17 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c8c58068cdf2997d338cd0b6e3109c5f773dbe6
Cr-Commit-Position: refs/heads/master@{#293663}

Powered by Google App Engine
This is Rietveld 408576698