[turbofan] Add ARM64 overflow selector tests

[turbofan] Add ARM64 overflow selector tests

Add more selector tests and correct a typo in the instruction selector code.

BUG=
R=bmeurer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23775

[m.m.capewell, 2014-09-05 10:28:26]

m.m.capewell@googlemail.com changed reviewers:
+ bmeurer@chromium.org, ulan@chromium.org

[Benedikt Meurer, 2014-09-05 10:31:26]

https://codereview.chromium.org/548453002/diff/1/src/compiler/arm64/instructi...
File src/compiler/arm64/instruction-selector-arm64-unittest.cc (right):

https://codereview.chromium.org/548453002/diff/1/src/compiler/arm64/instructi...
src/compiler/arm64/instruction-selector-arm64-unittest.cc:400: if
(strstr(dpi.constructor_name, "Add") != NULL) {
Hm, that looks rather fragile to me. Can we limit the test to Add instead?

https://codereview.chromium.org/548453002/diff/1/src/compiler/arm64/instructi...
src/compiler/arm64/instruction-selector-arm64-unittest.cc:457: if
(strstr(dpi.constructor_name, "Add") != NULL) {
Hm, that looks rather fragile to me. Can we limit the test to Add instead?

https://codereview.chromium.org/548453002/diff/1/src/compiler/arm64/instructi...
src/compiler/arm64/instruction-selector-arm64-unittest.cc:515: if
(strstr(dpi.constructor_name, "Add") != NULL) {
Hm, that looks rather fragile to me. Can we limit the test to Add instead?

[m.m.capewell, 2014-09-05 10:38:34]

https://codereview.chromium.org/548453002/diff/1/src/compiler/arm64/instructi...
File src/compiler/arm64/instruction-selector-arm64-unittest.cc (right):

https://codereview.chromium.org/548453002/diff/1/src/compiler/arm64/instructi...
src/compiler/arm64/instruction-selector-arm64-unittest.cc:400: if
(strstr(dpi.constructor_name, "Add") != NULL) {
On 2014/09/05 10:31:25, Benedikt Meurer wrote:
> Hm, that looks rather fragile to me. Can we limit the test to Add instead?

Sure, I'll replace these cases with TEST_F.

[m.m.capewell, 2014-09-05 14:26:52]

https://codereview.chromium.org/548453002/diff/1/src/compiler/arm64/instructi...
File src/compiler/arm64/instruction-selector-arm64-unittest.cc (right):

https://codereview.chromium.org/548453002/diff/1/src/compiler/arm64/instructi...
src/compiler/arm64/instruction-selector-arm64-unittest.cc:400: if
(strstr(dpi.constructor_name, "Add") != NULL) {
On 2014/09/05 10:31:25, Benedikt Meurer wrote:
> Hm, that looks rather fragile to me. Can we limit the test to Add instead?

Done.

https://codereview.chromium.org/548453002/diff/1/src/compiler/arm64/instructi...
src/compiler/arm64/instruction-selector-arm64-unittest.cc:457: if
(strstr(dpi.constructor_name, "Add") != NULL) {
On 2014/09/05 10:31:25, Benedikt Meurer wrote:
> Hm, that looks rather fragile to me. Can we limit the test to Add instead?

Done.

https://codereview.chromium.org/548453002/diff/1/src/compiler/arm64/instructi...
src/compiler/arm64/instruction-selector-arm64-unittest.cc:515: if
(strstr(dpi.constructor_name, "Add") != NULL) {
On 2014/09/05 10:31:25, Benedikt Meurer wrote:
> Hm, that looks rather fragile to me. Can we limit the test to Add instead?

Done.

[Benedikt Meurer, 2014-09-08 04:56:15]

Nice, thx. LGTM

[m.m.capewell, 2014-09-08 14:08:22]

Committed patchset #2 manually as 23775 (presubmit successful).