Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 548413002: Revert of Fix to keep the selection of the text field in input element after setSelectionRange... (Closed)

Created:
6 years, 3 months ago by ppi
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch, kenjibaheux
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Fix to keep the selection of the text field in input element after setSelectionRange is called by d… (patchset #7 id:160001 of https://codereview.chromium.org/507533002/) Reason for revert: Suspected cause of flaky failures of org.chromium.content.browser.input.ImeTest on Android bots - see http://crbug.com/411756 Original issue's description: > Fix to keep the selection of the text field in input element after setSelectionRange is called by dom events related to mouse > > The problem is that the selection is cleared when handling mouse release. > The selection should be kept if the selection is set by setSelectionRange during handling mouse event. > > BUG=32865 > R=yosin@chromium.org > R=rbyers@chromium.org > TEST=LayoutTests/fast/forms/setrangetext-within-events.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181490 TBR=yosin@chromium.org,yoichio@chromium.org,rbyers@chromium.org,kenjibaheux@chromium.org,myid.o.shin@gmail.com NOTREECHECKS=true NOTRY=true BUG=32865 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -96 lines) Patch
D LayoutTests/fast/forms/setrangetext-within-events.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/fast/forms/setrangetext-within-events-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/page/EventHandler.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ppi
6 years, 3 months ago (2014-09-08 15:56:08 UTC) #1
Created Revert of Fix to keep the selection of the text field in input element
after setSelectionRange is called by d…

Powered by Google App Engine
This is Rietveld 408576698