Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: tools/presubmit.py

Issue 548383002: Delete generated runtime tests (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/generate-runtime-tests.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/presubmit.py
diff --git a/tools/presubmit.py b/tools/presubmit.py
index 73fe587176ff9ee4c4657bfc973ef264c72d099b..8a6ff2af13423eefad75f1f31b34ed09c15c4cab 100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -417,10 +417,9 @@ class SourceProcessor(SourceFileProcessor):
return success
-def CheckGeneratedRuntimeTests(workspace):
+def CheckRuntimeVsNativesNameClashes(workspace):
code = subprocess.call(
- [sys.executable, join(workspace, "tools", "generate-runtime-tests.py"),
- "check"])
+ [sys.executable, join(workspace, "tools", "check-name-clashes.py")])
return code == 0
@@ -448,7 +447,7 @@ def Main():
print "Running copyright header, trailing whitespaces and " \
"two empty lines between declarations check..."
success = SourceProcessor().Run(workspace) and success
- success = CheckGeneratedRuntimeTests(workspace) and success
+ success = CheckRuntimeVsNativesNameClashes(workspace) and success
success = CheckExternalReferenceRegistration(workspace) and success
if success:
return 0
« no previous file with comments | « tools/generate-runtime-tests.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698