| OLD | NEW |
| 1 # Copyright 2012 the V8 project authors. All rights reserved. | 1 # Copyright 2012 the V8 project authors. All rights reserved. |
| 2 # Redistribution and use in source and binary forms, with or without | 2 # Redistribution and use in source and binary forms, with or without |
| 3 # modification, are permitted provided that the following conditions are | 3 # modification, are permitted provided that the following conditions are |
| 4 # met: | 4 # met: |
| 5 # | 5 # |
| 6 # * Redistributions of source code must retain the above copyright | 6 # * Redistributions of source code must retain the above copyright |
| 7 # notice, this list of conditions and the following disclaimer. | 7 # notice, this list of conditions and the following disclaimer. |
| 8 # * Redistributions in binary form must reproduce the above | 8 # * Redistributions in binary form must reproduce the above |
| 9 # copyright notice, this list of conditions and the following | 9 # copyright notice, this list of conditions and the following |
| 10 # disclaimer in the documentation and/or other materials provided | 10 # disclaimer in the documentation and/or other materials provided |
| (...skipping 23 matching lines...) Expand all Loading... |
| 34 import sys | 34 import sys |
| 35 | 35 |
| 36 | 36 |
| 37 def _V8PresubmitChecks(input_api, output_api): | 37 def _V8PresubmitChecks(input_api, output_api): |
| 38 """Runs the V8 presubmit checks.""" | 38 """Runs the V8 presubmit checks.""" |
| 39 import sys | 39 import sys |
| 40 sys.path.append(input_api.os_path.join( | 40 sys.path.append(input_api.os_path.join( |
| 41 input_api.PresubmitLocalPath(), 'tools')) | 41 input_api.PresubmitLocalPath(), 'tools')) |
| 42 from presubmit import CppLintProcessor | 42 from presubmit import CppLintProcessor |
| 43 from presubmit import SourceProcessor | 43 from presubmit import SourceProcessor |
| 44 from presubmit import CheckGeneratedRuntimeTests | 44 from presubmit import CheckRuntimeVsNativesNameClashes |
| 45 from presubmit import CheckExternalReferenceRegistration | 45 from presubmit import CheckExternalReferenceRegistration |
| 46 | 46 |
| 47 results = [] | 47 results = [] |
| 48 if not CppLintProcessor().Run(input_api.PresubmitLocalPath()): | 48 if not CppLintProcessor().Run(input_api.PresubmitLocalPath()): |
| 49 results.append(output_api.PresubmitError("C++ lint check failed")) | 49 results.append(output_api.PresubmitError("C++ lint check failed")) |
| 50 if not SourceProcessor().Run(input_api.PresubmitLocalPath()): | 50 if not SourceProcessor().Run(input_api.PresubmitLocalPath()): |
| 51 results.append(output_api.PresubmitError( | 51 results.append(output_api.PresubmitError( |
| 52 "Copyright header, trailing whitespaces and two empty lines " \ | 52 "Copyright header, trailing whitespaces and two empty lines " \ |
| 53 "between declarations check failed")) | 53 "between declarations check failed")) |
| 54 if not CheckGeneratedRuntimeTests(input_api.PresubmitLocalPath()): | 54 if not CheckRuntimeVsNativesNameClashes(input_api.PresubmitLocalPath()): |
| 55 results.append(output_api.PresubmitError( | 55 results.append(output_api.PresubmitError( |
| 56 "Generated runtime tests check failed")) | 56 "Runtime/natives name clash check failed")) |
| 57 if not CheckExternalReferenceRegistration(input_api.PresubmitLocalPath()): | 57 if not CheckExternalReferenceRegistration(input_api.PresubmitLocalPath()): |
| 58 results.append(output_api.PresubmitError( | 58 results.append(output_api.PresubmitError( |
| 59 "External references registration check failed")) | 59 "External references registration check failed")) |
| 60 return results | 60 return results |
| 61 | 61 |
| 62 | 62 |
| 63 def _CheckUnwantedDependencies(input_api, output_api): | 63 def _CheckUnwantedDependencies(input_api, output_api): |
| 64 """Runs checkdeps on #include statements added in this | 64 """Runs checkdeps on #include statements added in this |
| 65 change. Breaking - rules is an error, breaking ! rules is a | 65 change. Breaking - rules is an error, breaking ! rules is a |
| 66 warning. | 66 warning. |
| (...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 176 'v8_linux_nosnap_dbg': set(['defaulttests']), | 176 'v8_linux_nosnap_dbg': set(['defaulttests']), |
| 177 'v8_linux64_rel': set(['defaulttests']), | 177 'v8_linux64_rel': set(['defaulttests']), |
| 178 'v8_linux_arm_dbg': set(['defaulttests']), | 178 'v8_linux_arm_dbg': set(['defaulttests']), |
| 179 'v8_linux_arm64_rel': set(['defaulttests']), | 179 'v8_linux_arm64_rel': set(['defaulttests']), |
| 180 'v8_linux_layout_dbg': set(['defaulttests']), | 180 'v8_linux_layout_dbg': set(['defaulttests']), |
| 181 'v8_mac_rel': set(['defaulttests']), | 181 'v8_mac_rel': set(['defaulttests']), |
| 182 'v8_win_rel': set(['defaulttests']), | 182 'v8_win_rel': set(['defaulttests']), |
| 183 'v8_win64_rel': set(['defaulttests']), | 183 'v8_win64_rel': set(['defaulttests']), |
| 184 }, | 184 }, |
| 185 } | 185 } |
| OLD | NEW |