sync/api/attachments/fake_attachment_store.h - Issue 548373003: Move AttachmentStore ownership to datatype

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/api/attachments/fake_attachment_store.h

Issue 548373003: Move AttachmentStore ownership to datatype (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Changes after feedback. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/api/attachments/fake_attachment_store.h

diff --git a/sync/api/attachments/fake_attachment_store.h b/sync/api/attachments/fake_attachment_store.h

index 35fad173ac4bdbe30d8fcb54323849ff05f56395..9ac7006e7e5de469bfe793b03c569deb5901e9ed 100644

--- a/sync/api/attachments/fake_attachment_store.h

+++ b/sync/api/attachments/fake_attachment_store.h

@@ -36,8 +36,6 @@ class SYNC_EXPORT FakeAttachmentStore : public AttachmentStore {

explicit FakeAttachmentStore(

const scoped_refptr<base::SequencedTaskRunner>& backend_task_runner);

- virtual ~FakeAttachmentStore();

// AttachmentStore implementation.

virtual void Read(const AttachmentIdList& id,

const ReadCallback& callback) OVERRIDE;

@@ -49,6 +47,8 @@ class SYNC_EXPORT FakeAttachmentStore : public AttachmentStore {

private:

class Backend;

+ virtual ~FakeAttachmentStore();

scoped_refptr<Backend> backend_;

scoped_refptr<base::SequencedTaskRunner> backend_task_runner_;