components/sync_driver/sync_api_component_factory.h - Issue 548373003: Move AttachmentStore ownership to datatype

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/sync_api_component_factory.h

Issue 548373003: Move AttachmentStore ownership to datatype (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't create AttachmentService in GenericChangeProcessor if AttachmentStore is NULL Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync_driver/sync_api_component_factory.h

diff --git a/components/sync_driver/sync_api_component_factory.h b/components/sync_driver/sync_api_component_factory.h

index 3ca4f7338c2965f55b8645631774a678b529be66..2ae6dcb997d81264d6441f08fc67fe52894f9709 100644

--- a/components/sync_driver/sync_api_component_factory.h

+++ b/components/sync_driver/sync_api_component_factory.h

@@ -32,6 +32,7 @@ class SyncApiComponentFactory {

// provided. AttachmentService doesn't take ownership of delegate, the pointer

// must be valid throughout AttachmentService lifetime.

virtual scoped_ptr<syncer::AttachmentService> CreateAttachmentService(

+ const scoped_refptr<syncer::AttachmentStore>& attachment_store,

const syncer::UserShare& user_share,

syncer::AttachmentService::Delegate* delegate) = 0;

};