sync/internal_api/public/attachments/attachment_service_impl.h - Issue 548373003: Move AttachmentStore ownership to datatype

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/attachments/attachment_service_impl.h

Issue 548373003: Move AttachmentStore ownership to datatype (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: SyncableService related changes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/public/attachments/attachment_service_impl.h

diff --git a/sync/internal_api/public/attachments/attachment_service_impl.h b/sync/internal_api/public/attachments/attachment_service_impl.h

index 53f688982b8fdd77b6945580dae2aec22159d311..6d6660d37c5b4c822b8e451c1ce37accfc3e5449 100644

--- a/sync/internal_api/public/attachments/attachment_service_impl.h

+++ b/sync/internal_api/public/attachments/attachment_service_impl.h

@@ -33,7 +33,7 @@ class SYNC_EXPORT AttachmentServiceImpl : public AttachmentService,

// downloaded. Only attachments in |attachment_store| will be returned from

// GetOrDownloadAttachments.

- AttachmentServiceImpl(scoped_ptr<AttachmentStore> attachment_store,

+ AttachmentServiceImpl(scoped_refptr<AttachmentStore> attachment_store,

scoped_ptr<AttachmentUploader> attachment_uploader,

scoped_ptr<AttachmentDownloader> attachment_downloader,

Delegate* delegate);

@@ -69,7 +69,7 @@ class SYNC_EXPORT AttachmentServiceImpl : public AttachmentService,

const AttachmentDownloader::DownloadResult& result,

scoped_ptr<Attachment> attachment);

- const scoped_ptr<AttachmentStore> attachment_store_;

+ scoped_refptr<AttachmentStore> attachment_store_;

// May be null.

const scoped_ptr<AttachmentUploader> attachment_uploader_;