Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: chrome/browser/sync/profile_sync_components_factory_impl.h

Issue 548373003: Move AttachmentStore ownership to datatype (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Changes after feedback. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_components_factory_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__ 5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__ 6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 invalidation::InvalidationService* invalidator, 59 invalidation::InvalidationService* invalidator,
60 const base::WeakPtr<sync_driver::SyncPrefs>& sync_prefs, 60 const base::WeakPtr<sync_driver::SyncPrefs>& sync_prefs,
61 const base::FilePath& sync_folder) OVERRIDE; 61 const base::FilePath& sync_folder) OVERRIDE;
62 62
63 virtual scoped_ptr<browser_sync::LocalDeviceInfoProvider> 63 virtual scoped_ptr<browser_sync::LocalDeviceInfoProvider>
64 CreateLocalDeviceInfoProvider() OVERRIDE; 64 CreateLocalDeviceInfoProvider() OVERRIDE;
65 65
66 virtual base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType( 66 virtual base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType(
67 syncer::ModelType type) OVERRIDE; 67 syncer::ModelType type) OVERRIDE;
68 virtual scoped_ptr<syncer::AttachmentService> CreateAttachmentService( 68 virtual scoped_ptr<syncer::AttachmentService> CreateAttachmentService(
69 const scoped_refptr<syncer::AttachmentStore>& attachment_store,
69 const syncer::UserShare& user_share, 70 const syncer::UserShare& user_share,
70 syncer::AttachmentService::Delegate* delegate) OVERRIDE; 71 syncer::AttachmentService::Delegate* delegate) OVERRIDE;
71 72
72 // Legacy datatypes that need to be converted to the SyncableService API. 73 // Legacy datatypes that need to be converted to the SyncableService API.
73 virtual SyncComponents CreateBookmarkSyncComponents( 74 virtual SyncComponents CreateBookmarkSyncComponents(
74 ProfileSyncService* profile_sync_service, 75 ProfileSyncService* profile_sync_service,
75 sync_driver::DataTypeErrorHandler* error_handler) OVERRIDE; 76 sync_driver::DataTypeErrorHandler* error_handler) OVERRIDE;
76 virtual SyncComponents CreateTypedUrlSyncComponents( 77 virtual SyncComponents CreateTypedUrlSyncComponents(
77 ProfileSyncService* profile_sync_service, 78 ProfileSyncService* profile_sync_service,
78 history::HistoryBackend* history_backend, 79 history::HistoryBackend* history_backend,
(...skipping 27 matching lines...) Expand all
106 const GURL sync_service_url_; 107 const GURL sync_service_url_;
107 OAuth2TokenService* const token_service_; 108 OAuth2TokenService* const token_service_;
108 net::URLRequestContextGetter* const url_request_context_getter_; 109 net::URLRequestContextGetter* const url_request_context_getter_;
109 110
110 base::WeakPtrFactory<ProfileSyncComponentsFactoryImpl> weak_factory_; 111 base::WeakPtrFactory<ProfileSyncComponentsFactoryImpl> weak_factory_;
111 112
112 DISALLOW_COPY_AND_ASSIGN(ProfileSyncComponentsFactoryImpl); 113 DISALLOW_COPY_AND_ASSIGN(ProfileSyncComponentsFactoryImpl);
113 }; 114 };
114 115
115 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__ 116 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_components_factory_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698