Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: components/sync_driver/shared_change_processor_unittest.cc

Issue 548373003: Move AttachmentStore ownership to datatype (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't create AttachmentService in GenericChangeProcessor if AttachmentStore is NULL Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync_driver/shared_change_processor.h" 5 #include "components/sync_driver/shared_change_processor.h"
6 6
7 #include <cstddef> 7 #include <cstddef>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 26 matching lines...) Expand all
37 virtual ~SyncSharedChangeProcessorTest() { 37 virtual ~SyncSharedChangeProcessorTest() {
38 EXPECT_FALSE(db_syncable_service_.get()); 38 EXPECT_FALSE(db_syncable_service_.get());
39 } 39 }
40 40
41 virtual base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType( 41 virtual base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType(
42 syncer::ModelType type) OVERRIDE { 42 syncer::ModelType type) OVERRIDE {
43 return db_syncable_service_->AsWeakPtr(); 43 return db_syncable_service_->AsWeakPtr();
44 } 44 }
45 45
46 virtual scoped_ptr<syncer::AttachmentService> CreateAttachmentService( 46 virtual scoped_ptr<syncer::AttachmentService> CreateAttachmentService(
47 const scoped_refptr<syncer::AttachmentStore>& attachment_store,
47 const syncer::UserShare& user_share, 48 const syncer::UserShare& user_share,
48 syncer::AttachmentService::Delegate* delegate) OVERRIDE { 49 syncer::AttachmentService::Delegate* delegate) OVERRIDE {
49 return syncer::AttachmentServiceImpl::CreateForTest(); 50 return syncer::AttachmentServiceImpl::CreateForTest();
50 } 51 }
51 52
52 protected: 53 protected:
53 virtual void SetUp() OVERRIDE { 54 virtual void SetUp() OVERRIDE {
54 shared_change_processor_ = new SharedChangeProcessor(); 55 shared_change_processor_ = new SharedChangeProcessor();
55 ASSERT_TRUE(backend_thread_.Start()); 56 ASSERT_TRUE(backend_thread_.Start());
56 ASSERT_TRUE(backend_thread_.message_loop_proxy()->PostTask( 57 ASSERT_TRUE(backend_thread_.message_loop_proxy()->PostTask(
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 137
137 // Simply connect the shared change processor. It should succeed, and 138 // Simply connect the shared change processor. It should succeed, and
138 // nothing further should happen. 139 // nothing further should happen.
139 TEST_F(SyncSharedChangeProcessorTest, Basic) { 140 TEST_F(SyncSharedChangeProcessorTest, Basic) {
140 Connect(); 141 Connect();
141 } 142 }
142 143
143 } // namespace 144 } // namespace
144 145
145 } // namespace sync_driver 146 } // namespace sync_driver
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698