mojo: Specialize native type arrays.

mojo/public/tools/bindings/generators/mojom_python_generator.py

Index: mojo/public/tools/bindings/generators/mojom_python_generator.py
diff --git a/mojo/public/tools/bindings/generators/mojom_python_generator.py b/mojo/public/tools/bindings/generators/mojom_python_generator.py
index 9417298d4b3cf5d01f8b098658b4379ebe3090de..a60ee15b6aaceae5350e85316f1525e3fe38606a 100644
--- a/mojo/public/tools/bindings/generators/mojom_python_generator.py
+++ b/mojo/public/tools/bindings/generators/mojom_python_generator.py
@@ -37,6 +37,18 @@ _kind_to_type = {
   mojom.NULLABLE_SHAREDBUFFER: "_descriptor.TYPE_NULLABLE_HANDLE",
 }
 
+# int64 integers are not handled by array.array

[Chris Masone, 2014/09/09 14:20:26]

Hm. That's a bit of an issue, as many CrOS platforms are 64 bit, and integers
are that wide by default. Is there a way to work around this?

[qsr, 2014/09/09 14:30:20]

 Hum... Not sure to understand why this is an issue. That would only be used to
efficiently handle array of 64 bytes integer in generated struct. This is quite
a rare type in the mojom files anyway, so the fact that we use a python list to
represent those and encode those instead of a array.array is not that much of an
issue. It would be great to have a closer to native representation for those,
but I don't think the performance hit is such a problem given that I do not
expect those to be used a lot. For example, right now in chromium:

git grep int64\\\[ -- \*.mojom | wc -l
0

[sdefresne, 2014/09/10 08:40:00]

Maybe expand the comment to say that int64/uint64 array are supported but
storage is not optimized (ie. they are plain python list, not array.array).

[qsr, 2014/09/10 09:23:38]

Done.

+_kind_to_typecode = {
+  mojom.INT8:   "'b'",
+  mojom.UINT8:  "'B'",
+  mojom.INT16:  "'h'",
+  mojom.UINT16: "'H'",
+  mojom.INT32:  "'i'",
+  mojom.UINT32: "'I'",
+  mojom.FLOAT:  "'f'",
+  mojom.DOUBLE: "'d'",
+}
+
 
 def NameToComponent(name):
   # insert '_' between anything and a Title name (e.g, HTTPEntry2FooBar ->
@@ -99,12 +111,18 @@ def GetStructClass(kind):
 
 def GetFieldType(kind, field=None):
   if mojom.IsAnyArrayKind(kind):
-    arguments = [ GetFieldType(kind.kind) ]
+    if kind.kind in _kind_to_typecode:
+      arguments = [ _kind_to_typecode[kind.kind] ]
+    else:
+      arguments = [ GetFieldType(kind.kind) ]
     if mojom.IsNullableKind(kind):
       arguments.append("nullable=True")
     if mojom.IsFixedArrayKind(kind):
       arguments.append("length=%d" % kind.length)
-    return "_descriptor.ArrayType(%s)" % ", ".join(arguments)
+    if kind.kind in _kind_to_typecode:
+      return "_descriptor.NativeArrayType(%s)" % ", ".join(arguments)
+    else:
+      return "_descriptor.PointerArrayType(%s)" % ", ".join(arguments)
 
   if mojom.IsStructKind(kind):
     arguments = [ GetStructClass(kind) ]