Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 548343004: Move chrome/test/data/gdata/testfile.txt to chrome/test/data/drive (Closed)

Created:
6 years, 3 months ago by satorux1
Modified:
6 years, 3 months ago
Reviewers:
yoshiki
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move chrome/test/data/gdata/testfile.txt to chrome/test/data/drive chrome/test/data/gdata will be removed once WAPI code is removed, hence google_apis/drive/drive_api_requests_unittest.cc should stop using chrome/test/data/gdata/testfile.txt BUG=412238 TEST=no change to production binary. google_apis_unittests should pass as before Committed: https://crrev.com/6b0a1859436920c9f18aeb125535eeab95571454 Cr-Commit-Position: refs/heads/master@{#294121}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
A + chrome/test/data/drive/testfile.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/gdata/testfile.txt View 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/drive/base_requests_server_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/gdata_wapi_requests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
satorux1
6 years, 3 months ago (2014-09-09 06:41:27 UTC) #2
yoshiki
lgtm
6 years, 3 months ago (2014-09-10 05:21:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/548343004/20001
6 years, 3 months ago (2014-09-10 05:31:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ce665dc5326cff58e5ed72247986fd3200bff575
6 years, 3 months ago (2014-09-10 06:23:36 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 06:26:52 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b0a1859436920c9f18aeb125535eeab95571454
Cr-Commit-Position: refs/heads/master@{#294121}

Powered by Google App Engine
This is Rietveld 408576698