When parsing arguments on Windows, check malloc() for failure.

When parsing arguments on Windows, check malloc() for failure.

Note: this code is only executed by Skia utilities AFAIK, not by
external clients.

BUG=skia:2642
Committed: https://skia.googlesource.com/skia/+/4459a0448d84d4adb53984227fbee4c581f13a98

[Stephen White, 2014-09-08 14:58:54]

senorblanco@chromium.org changed reviewers:
+ robertphillips@google.com

[Stephen White, 2014-09-08 14:59:06]

Rob: PTAL. Thanks!

[reed1, 2014-09-08 15:14:24]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2014-09-08 15:14:25]

1. Even our utils should probably call sk_malloc_throw instead of raw malloc

2. Is the NULL real? If so, are we passing some absurd length (i.e. a bug)?

[Stephen White, 2014-09-08 15:28:00]

On 2014/09/08 15:14:25, reed1 wrote:
> 1. Even our utils should probably call sk_malloc_throw instead of raw malloc

Good idea; will do.

> 2. Is the NULL real? If so, are we passing some absurd length (i.e. a bug)?

I doubt it. I suspect that this is the result of some static analysis tool
(see the bug).

[Stephen White, 2014-09-08 16:25:46]

senorblanco@chromium.org changed reviewers:
- robertphillips@google.com

[Stephen White, 2014-09-08 16:25:47]

reed@: PTAL. Thanks!

[Stephen White, 2014-09-09 19:14:02]

reed@: ping?

[reed1, 2014-09-09 19:16:45]

lgtm

[Stephen White, 2014-09-09 19:26:44]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2014-09-09 19:27:45]

CQ is trying da patch. Follow status at

https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/548343002/40001

[commit-bot: I haz the power, 2014-09-09 19:37:19]

Committed patchset #3 (id:40001) as 4459a0448d84d4adb53984227fbee4c581f13a98