Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 548333002: Revert of Revert of Forward input and compositing tasks to the Blink scheduler (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
CC:
chromium-reviews, jam, cc-bugs_chromium.org, jdduke+watch_chromium.org, darin-cc_chromium.org, mithro-old
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Forward input and compositing tasks to the Blink scheduler (patchset #1 id:1 of https://codereview.chromium.org/548253002/) Reason for revert: this didn't reduce flakiness Original issue's description: > Revert of Forward input and compositing tasks to the Blink scheduler (patchset #21 id:400001 of https://codereview.chromium.org/363383002/) > > Reason for revert: > suspecting it's causing the high rate of flakes in Instrumentation test ContentShellTest > > BUG=411756 > > Original issue's description: > > Forward input and compositing tasks to the Blink scheduler > > > > Instead of posting input and compositor tasks directly to the > > main thread message loop, forward them to the Blink scheduler > > so they can be prioritized over other tasks. > > > > BUG=391005 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290845 > > > > Committed: https://chromium.googlesource.com/chromium/src/+/68bab3290b45a8610ad875d3c92530477c16a948 > > TBR=jamesr@chromium.org,alexclarke@chromium.org,picksi@chromium.org,eseidel@chromium.org,skyostil@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=391005 > > Committed: https://chromium.googlesource.com/chromium/src/+/66f85d5405417e6ddd11e1b9be677062a2e3ae4f TBR=jamesr@chromium.org,alexclarke@chromium.org,picksi@chromium.org,eseidel@chromium.org,skyostil@chromium.org NOTREECHECKS=true NOTRY=true BUG=411756 Committed: https://crrev.com/479004ba3d84ec815444e9279adcda7ed056afcb Cr-Commit-Position: refs/heads/master@{#293722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -23 lines) Patch
M content/content_renderer.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M content/renderer/input/input_event_filter.h View 3 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/input/input_event_filter.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/input/input_event_filter_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +10 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 6 chunks +13 lines, -2 lines 0 comments Download
A content/renderer/scheduler_proxy_task_runner.h View 1 chunk +87 lines, -0 lines 0 comments Download
A content/renderer/scheduler_proxy_task_runner_browsertest.cc View 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Revert of Forward input and compositing tasks to the Blink scheduler
6 years, 3 months ago (2014-09-08 14:36:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/548333002/1
6 years, 3 months ago (2014-09-08 14:38:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 84f27546bec0deecdf15e28ab1fd85a40e7226f4
6 years, 3 months ago (2014-09-08 14:41:44 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:46:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/479004ba3d84ec815444e9279adcda7ed056afcb
Cr-Commit-Position: refs/heads/master@{#293722}

Powered by Google App Engine
This is Rietveld 408576698