Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 548323003: Non-plafrom-specific part of an OwnerSettingsService is moved to components/ownership/*. (Closed)

Created:
6 years, 3 months ago by ygorshenin1
Modified:
6 years, 3 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fixes. #

Total comments: 2

Patch Set 3 : Rebase, fixes. #

Patch Set 4 : Added explicit conversion from scoped_ptr to bool when it's needed. #

Patch Set 5 : Fixed components/ownership.gypi. #

Patch Set 6 : Rebase. #

Patch Set 7 : Fixes to *.gypi and *.gn files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+532 lines, -1268 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/chromeos/ownership/owner_settings_service.h View 1 2 1 chunk +0 lines, -154 lines 0 comments Download
D chrome/browser/chromeos/ownership/owner_settings_service.cc View 1 2 1 chunk +0 lines, -517 lines 0 comments Download
A + chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h View 1 2 4 chunks +31 lines, -64 lines 0 comments Download
A + chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 1 2 12 chunks +70 lines, -261 lines 0 comments Download
A + chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h View 4 chunks +12 lines, -13 lines 0 comments Download
A + chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.cc View 3 chunks +18 lines, -15 lines 0 comments Download
D chrome/browser/chromeos/ownership/owner_settings_service_factory.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/chromeos/ownership/owner_settings_service_factory.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.h View 5 chunks +6 lines, -45 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.cc View 5 chunks +100 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service_unittest.cc View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation_unittest.cc View 1 2 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M components/ownership.gypi View 1 2 3 4 5 6 2 chunks +9 lines, -0 lines 0 comments Download
M components/ownership/BUILD.gn View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
M components/ownership/DEPS View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A components/ownership/owner_settings_service.h View 1 1 chunk +102 lines, -0 lines 0 comments Download
A components/ownership/owner_settings_service.cc View 1 2 3 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (4 generated)
ygorshenin1
+ Nikita for chrome/browser/chromeos/* + Julian for chrome/browser/chromeos/settings/*
6 years, 3 months ago (2014-09-08 15:02:59 UTC) #2
ygorshenin1
+ erg@ for chrome/browser/profiles/* and components/ownership/DEPS + jochen@ for chrome/chrome_browser_chromeos.gypi
6 years, 3 months ago (2014-09-10 11:20:21 UTC) #4
ygorshenin1
6 years, 3 months ago (2014-09-10 11:21:19 UTC) #6
pastarmovj
chromeos/settings/* lgtm
6 years, 3 months ago (2014-09-10 16:40:59 UTC) #7
Elliot Glaysher
rename in profiles lgtm
6 years, 3 months ago (2014-09-10 17:33:03 UTC) #8
Nikita (slow)
lgtm https://codereview.chromium.org/548323003/diff/1/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h File chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h (right): https://codereview.chromium.org/548323003/diff/1/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h#newcode31 chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h:31: // This class reloads owner key from profile ...
6 years, 3 months ago (2014-09-10 18:05:12 UTC) #9
ygorshenin1
jochen@, could you please take a look at components/*? https://codereview.chromium.org/548323003/diff/1/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h File chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h (right): https://codereview.chromium.org/548323003/diff/1/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h#newcode31 chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h:31: ...
6 years, 3 months ago (2014-09-11 14:06:21 UTC) #10
jochen (gone - plz use gerrit)
https://codereview.chromium.org/548323003/diff/20001/components/ownership/DEPS File components/ownership/DEPS (right): https://codereview.chromium.org/548323003/diff/20001/components/ownership/DEPS#newcode2 components/ownership/DEPS:2: "+components/keyed_service", if you need keyed_service, the gyp and gn ...
6 years, 3 months ago (2014-09-12 13:56:16 UTC) #11
jochen (gone - plz use gerrit)
lgtm with nit addressed
6 years, 3 months ago (2014-09-12 13:58:21 UTC) #12
ygorshenin1
Many thanks! https://codereview.chromium.org/548323003/diff/20001/components/ownership/DEPS File components/ownership/DEPS (right): https://codereview.chromium.org/548323003/diff/20001/components/ownership/DEPS#newcode2 components/ownership/DEPS:2: "+components/keyed_service", On 2014/09/12 13:56:16, jochen wrote: > ...
6 years, 3 months ago (2014-09-12 15:15:55 UTC) #13
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/46a58bffbe303d3484d7cc288b47bfae5388109c Cr-Commit-Position: refs/heads/master@{#294609}
6 years, 3 months ago (2014-09-12 17:24:55 UTC) #14
ygorshenin1
Committed patchset #4 (id:60001) manually as 46a58bf.
6 years, 3 months ago (2014-09-12 17:25:01 UTC) #15
nasko
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/565293003/ by nasko@chromium.org. ...
6 years, 3 months ago (2014-09-12 17:54:19 UTC) #16
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/40979bf265c3ffbe1736a87935418da72be5d1f1 Cr-Commit-Position: refs/heads/master@{#294793}
6 years, 3 months ago (2014-09-15 09:11:12 UTC) #18
ygorshenin1
Committed patchset #5 (id:100001) manually as 40979bf.
6 years, 3 months ago (2014-09-15 09:12:09 UTC) #19
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/c7bf410deedf2ee6be9439411ea362341c63bc43 Cr-Commit-Position: refs/heads/master@{#294810}
6 years, 3 months ago (2014-09-15 13:16:12 UTC) #20
ygorshenin1
6 years, 3 months ago (2014-09-15 13:20:18 UTC) #21
Message was sent while issue was closed. 
Committed patchset #7 (id:140001) manually as c7bf410.

Powered by Google App Engine
This is Rietveld 408576698